Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esclient stats #33621

Merged
merged 9 commits into from
Nov 21, 2022
Merged

Add esclient stats #33621

merged 9 commits into from
Nov 21, 2022

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Nov 9, 2022

What does this PR do?

This PR updates the Kibana module of metricbeat, enriching the stats metricset with connectivity information from elasticsearch-js client, exposed in /api/stats through #141434.

Why is it important?

The goal is for metricbeat to ingest these new fields, and ship them into the overview cluster, for internal consumption. This information might be very relevant for SDH investigations, whenever there are performance concerns or connectivity errors. We can contrast it with response times to find correlations, or even analyse it individually to detect anomalies (e.g. workload not being properly balanced across ES nodes).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@gsoldevila gsoldevila requested a review from a team as a code owner November 9, 2022 15:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 9, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @gsoldevila? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@gsoldevila gsoldevila added backport-skip Skip notification from the automated backport with mergify v8.6.0 Team:Observability Team:Core labels Nov 9, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 9, 2022
@gsoldevila gsoldevila added Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring and removed Team:Observability labels Nov 9, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-18T11:21:47.977+0000

  • Duration: 54 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 3931
Skipped 877
Total 4808

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klacabane, we probably need to add these new fields to Kibana integration package.

@gsoldevila gsoldevila added v8.7.0 and removed v8.6.0 labels Nov 17, 2022
@rudolf
Copy link
Contributor

rudolf commented Nov 21, 2022

@crespocarlos We're not able to merge this, will you do that?

@crespocarlos crespocarlos merged commit cf243c3 into elastic:main Nov 21, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Add elasticsearch-client-js sockets info to stats metricset

* Fix data.go indenting

* Update type of protocol field

* Run make update and commit results

* Fix lint errors

* Update a couple of field types

* Run make update

* Collect only most interesting stats

Co-authored-by: Rudolf Meijering <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Team:Core Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants