-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esclient stats #33621
Add esclient stats #33621
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@klacabane, we probably need to add these new fields to Kibana integration package.
@crespocarlos We're not able to merge this, will you do that? |
* Add elasticsearch-client-js sockets info to stats metricset * Fix data.go indenting * Update type of protocol field * Run make update and commit results * Fix lint errors * Update a couple of field types * Run make update * Collect only most interesting stats Co-authored-by: Rudolf Meijering <[email protected]>
What does this PR do?
This PR updates the Kibana module of metricbeat, enriching the
stats
metricset with connectivity information from elasticsearch-js client, exposed in/api/stats
through #141434.Why is it important?
The goal is for metricbeat to ingest these new fields, and ship them into the overview cluster, for internal consumption. This information might be very relevant for SDH investigations, whenever there are performance concerns or connectivity errors. We can contrast it with response times to find correlations, or even analyse it individually to detect anomalies (e.g. workload not being properly balanced across ES nodes).
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs