Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.11](backport #33318)[DOCS] Fix hard-coded documentation link (#33318) #33604

Closed
wants to merge 1 commit into from
Closed

[7.11](backport #33318)[DOCS] Fix hard-coded documentation link (#33318) #33604

wants to merge 1 commit into from

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 7, 2022 •
edited
Loading

Backports #33318

This PR fixes the following hard-coded link, which will fail when we move away from "master" URLs:

17:07:03 INFO:build_docs: /tmp/docsbuild/target_repo/html/en/beats/devguide/8.5/creating-metricbeat-module.html contains broken links to:
17:07:03 INFO:build_docs: - en/beats/metricbeat/master/metricbeat-module-mysql.html

(cherry picked from commit b8b87c3)

@lcawl
[DOCS] Fix hard-coded documentation link (elastic#33318)
92bfb33 
This PR fixes the following hard-coded link, which will fail when we move away from "master" URLs:

> 17:07:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/beats/devguide/8.5/creating-metricbeat-module.html contains broken links to:
17:07:03 INFO:build_docs:   - en/beats/metricbeat/master/metricbeat-module-mysql.html

(cherry picked from commit b8b87c3)
@lcawl lcawl added backport Team:Docs Label for the Observability docs team labels Nov 7, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 7, 2022
@mergify mergify bot assigned lcawl Nov 7, 2022
@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-07T19:57:58.151+0000

  • Duration: 14 min 14 sec

Steps errors 2

Expand to view the steps failures

make check
  • Took 6 min 41 sec . View more details here
  • Description: make check
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review November 7, 2022 21:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@lcawl lcawl requested a review from a team November 8, 2022 15:23
@lcawl lcawl closed this Feb 7, 2023
@lcawl lcawl deleted the 711-33318 branch February 7, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lcawl lcawl

Labels
backport Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @elasticmachine