Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17](backport #33318) [DOCS] Fix hard-coded documentation link #33502

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[7.17](backport #33318) [DOCS] Fix hard-coded documentation link #33502

merged 2 commits into from
Dec 5, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 31, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #33318 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@lcawl @mergify
[DOCS] Fix hard-coded documentation link (#33318)
b13e683 
This PR fixes the following hard-coded link, which will fail when we move away from "master" URLs:

> 17:07:03 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/beats/devguide/8.5/creating-metricbeat-module.html contains broken links to:
17:07:03 INFO:build_docs:   - en/beats/metricbeat/master/metricbeat-module-mysql.html

(cherry picked from commit b8b87c3)
@mergify mergify bot requested a review from a team as a code owner October 31, 2022 15:25
@mergify mergify bot added the backport label Oct 31, 2022
@mergify mergify bot requested review from cmacknz and leehinman and removed request for a team October 31, 2022 15:25
@mergify mergify bot assigned lcawl Oct 31, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 31, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 31, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-07T19:34:33.702+0000

  • Duration: 8 min 25 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor Author

mergify bot commented Nov 7, 2022

This pull request has not been merged yet. Could you please review and merge it @lcawl? 🙏

@lcawl lcawl added the Team:Docs Label for the Observability docs team label Nov 7, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 7, 2022
@mergify
Copy link
Contributor Author

mergify bot commented Nov 14, 2022

This pull request has not been merged yet. Could you please review and merge it @lcawl? 🙏

3 similar comments
@mergify
Copy link
Contributor Author

mergify bot commented Nov 21, 2022

This pull request has not been merged yet. Could you please review and merge it @lcawl? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Nov 28, 2022

This pull request has not been merged yet. Could you please review and merge it @lcawl? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Dec 5, 2022

This pull request has not been merged yet. Could you please review and merge it @lcawl? 🙏

@bmorelli25 bmorelli25 merged commit 83558e2 into 7.17 Dec 5, 2022
@bmorelli25 bmorelli25 deleted the mergify/bp/7.17/pr-33318 branch December 5, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@lcawl lcawl

Labels
backport Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @bmorelli25 @lcawl