-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enricher to storageclass metricset #33032
Add enricher to storageclass metricset #33032
Conversation
Signed-off-by: Tetiana Kravchenko <[email protected]>
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Signed-off-by: Tetiana Kravchenko <[email protected]>
"reclaimPolicy": p.Label("reclaim_policy"), | ||
"reclaim_policy": p.Label("reclaim_policy"), | ||
"volumeBindingMode": p.Label("volume_binding_mode"), | ||
"volume_binding_mode": p.Label("volume_binding_mode"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this here? Is it different than volumeBindingMode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it was changed in kube-state-metrics v2 - https://github.com/kubernetes/kube-state-metrics/pull/1107/files and reclaimPolicy
was renamed to reclaim_policy
, and volumeBindingMode
to volume_binding_mode
to support both versions of kube-state-metrics I've added this to mapping (< 2.0 - used reclaimPolicy
and volumeBindingMode
, example - https://github.com/elastic/beats/blob/main/metricbeat/module/kubernetes/_meta/test/ksm.v1.8.0#L1370, versions > 2.0 - https://github.com/elastic/beats/blob/main/metricbeat/module/kubernetes/_meta/test/ksm.v2.0.0#L1545)
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko <[email protected]>
This pull request is now in conflicts. Could you fix it? 🙏
|
* add enricher for storageclass Signed-off-by: Tetiana Kravchenko <[email protected]> * add pr number Signed-off-by: Tetiana Kravchenko <[email protected]> * fix check-no-changes] Error 1 Signed-off-by: Tetiana Kravchenko <[email protected]> * generate notice file Signed-off-by: Tetiana Kravchenko <[email protected]> * readd removed metric from test file Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> (cherry picked from commit d20fff4) # Conflicts: # NOTICE.txt # go.mod # go.sum
* add enricher for storageclass Signed-off-by: Tetiana Kravchenko <[email protected]> * add pr number Signed-off-by: Tetiana Kravchenko <[email protected]> * fix check-no-changes] Error 1 Signed-off-by: Tetiana Kravchenko <[email protected]> * generate notice file Signed-off-by: Tetiana Kravchenko <[email protected]> * readd removed metric from test file Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> (cherry picked from commit d20fff4) # Conflicts: # go.mod # go.sum
* Add enricher to storageclass metricset (#33032) * add enricher for storageclass Signed-off-by: Tetiana Kravchenko <[email protected]> * add pr number Signed-off-by: Tetiana Kravchenko <[email protected]> * fix check-no-changes] Error 1 Signed-off-by: Tetiana Kravchenko <[email protected]> * generate notice file Signed-off-by: Tetiana Kravchenko <[email protected]> * readd removed metric from test file Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> (cherry picked from commit d20fff4) # Conflicts: # go.mod # go.sum * Update go.mod * Update go.sum * update elastic-agent-libs to pass tests Signed-off-by: Tetiana Kravchenko <[email protected]> * run make check-default Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> Co-authored-by: Tetiana Kravchenko <[email protected]>
* Add enricher to storageclass metricset (#33032) * add enricher for storageclass Signed-off-by: Tetiana Kravchenko <[email protected]> * add pr number Signed-off-by: Tetiana Kravchenko <[email protected]> * fix check-no-changes] Error 1 Signed-off-by: Tetiana Kravchenko <[email protected]> * generate notice file Signed-off-by: Tetiana Kravchenko <[email protected]> * readd removed metric from test file Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> (cherry picked from commit d20fff4) # Conflicts: # NOTICE.txt # go.mod # go.sum * fix conflicts Signed-off-by: Tetiana Kravchenko <[email protected]> * run make check-default; replace mod.GetMetricsRepo -> mod.GetPerfMetricsCache Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> Co-authored-by: Tetiana Kravchenko <[email protected]>
* add enricher for storageclass Signed-off-by: Tetiana Kravchenko <[email protected]> * add pr number Signed-off-by: Tetiana Kravchenko <[email protected]> * fix check-no-changes] Error 1 Signed-off-by: Tetiana Kravchenko <[email protected]> * generate notice file Signed-off-by: Tetiana Kravchenko <[email protected]> * readd removed metric from test file Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]>
Signed-off-by: Tetiana Kravchenko [email protected]
What does this PR do?
Add missing orchestrator.cluster.name and orchestrator.cluster.url fields to
state_storageclass
metricset.Why is it important?
orchestrator.cluster.name is used for kubernetes dashboards
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs