-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.3](backport #32979) Add missing cluster metadata to multiple k8s metricsests #33019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add missing field Signed-off-by: Tetiana Kravchenko <[email protected]> * update log message Signed-off-by: Tetiana Kravchenko <[email protected]> * fix tests Signed-off-by: Tetiana Kravchenko <[email protected]> * add pr number Signed-off-by: Tetiana Kravchenko <[email protected]> * volume metricset: replace adding ECS orchestrator fields with util.AddClusterECSMeta Signed-off-by: Tetiana Kravchenko <[email protected]> Signed-off-by: Tetiana Kravchenko <[email protected]> (cherry picked from commit 1f5b863) # Conflicts: # metricbeat/module/kubernetes/apiserver/_meta/test/metrics.1.14.expected # metricbeat/module/kubernetes/apiserver/apiserver.go # metricbeat/module/kubernetes/apiserver/metricset.go # metricbeat/module/kubernetes/controllermanager/_meta/test/metrics.1.20.expected # metricbeat/module/kubernetes/controllermanager/controllermanager.go
mergify
bot
added
backport
conflicts
There is a conflict in the backported pull request
labels
Sep 8, 2022
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 8, 2022
This pull request doesn't have a |
Collaborator
This pull request has not been merged yet. Could you please review and merge it @tetianakravchenko? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
conflicts
There is a conflict in the backported pull request
needs_team
Indicates that the issue/PR needs a Team:* label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #32979 done by Mergify.
Cherry-pick of 1f5b863 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com