-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packetbeat: reduce levels of indirection, simplify and document #32721
Conversation
This can be reintroduced if it becomes necessary.
This pull request does not have a backport label.
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ godocs ✍️
packetbeat/sniffer/worker.go
Outdated
@@ -15,7 +15,7 @@ | |||
// specific language governing permissions and limitations | |||
// under the License. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this file should be decoders.go
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
* packetbeat: simplify source layout and add some docs * packetbeat/sniffer: remove unnecessary interface type
What does this PR do?
This clarifies the intentions of the code by impoving source locality, removing unneeded indirection and adding documentation.
Why is it important?
This will help in maintenance and when adding new features.
Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inNot user-facingCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs