-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] gcp-pubsub: Restart Pub/Sub client on errors #32712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the gcp-pubsub input in Filebeat to include its own retry loop rather than being entirely dependent upon the pub/sub client SDK to retry requests. The input will only exit when the shutdown is triggered by Filebeat. Any errors generated by the pub/sub client will be logged and then the input will restart the pub/sub client. It will throttle restarts to once per 30s. Fixes elastic#32550
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 16, 2022
andrewkroh
added
bug
Filebeat
Filebeat
Team:Security-External Integrations
backport-v8.4.0
Automated backport with mergify
labels
Aug 16, 2022
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Aug 16, 2022
andrewkroh
added
the
backport-7.17
Automated backport to the 7.17 branch with mergify
label
Aug 16, 2022
andrewkroh
changed the title
[Filebeat] gcp-pubsub - Restart Pub/Sub client on errors
[Filebeat] gcp-pubsub: Restart Pub/Sub client on errors
Aug 16, 2022
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Collaborator
efd6
approved these changes
Aug 16, 2022
Co-authored-by: Dan Kortschak <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
This modifies the gcp-pubsub input in Filebeat to include its own retry loop rather than being entirely dependent upon the pub/sub client SDK to retry requests. The input will only exit when the shutdown is triggered by Filebeat. Any errors generated by the pub/sub client will be logged and then the input will restart the pub/sub client. It will throttle restarts to once per 30s. Fixes #32550 (cherry picked from commit 947c837)
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2022
This modifies the gcp-pubsub input in Filebeat to include its own retry loop rather than being entirely dependent upon the pub/sub client SDK to retry requests. The input will only exit when the shutdown is triggered by Filebeat. Any errors generated by the pub/sub client will be logged and then the input will restart the pub/sub client. It will throttle restarts to once per 30s. Fixes #32550 (cherry picked from commit 947c837)
v1v
pushed a commit
to v1v/beats
that referenced
this pull request
Aug 22, 2022
… client on errors (elastic#32716) This modifies the gcp-pubsub input in Filebeat to include its own retry loop rather than being entirely dependent upon the pub/sub client SDK to retry requests. The input will only exit when the shutdown is triggered by Filebeat. Any errors generated by the pub/sub client will be logged and then the input will restart the pub/sub client. It will throttle restarts to once per 30s. Fixes elastic#32550 (cherry picked from commit 947c837) Co-authored-by: Andrew Kroh <[email protected]>
cmacknz
pushed a commit
that referenced
this pull request
Aug 24, 2022
…on errors (#32717) This modifies the gcp-pubsub input in Filebeat to include its own retry loop rather than being entirely dependent upon the pub/sub client SDK to retry requests. The input will only exit when the shutdown is triggered by Filebeat. Any errors generated by the pub/sub client will be logged and then the input will restart the pub/sub client. It will throttle restarts to once per 30s. Fixes #32550 (cherry picked from commit 947c837) Co-authored-by: Andrew Kroh <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
This modifies the gcp-pubsub input in Filebeat to include its own retry loop rather than being entirely dependent upon the pub/sub client SDK to retry requests. The input will only exit when the shutdown is triggered by Filebeat. Any errors generated by the pub/sub client will be logged and then the input will restart the pub/sub client. It will throttle restarts to once per 30s. Fixes #32550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.17
Automated backport to the 7.17 branch with mergify
backport-v8.4.0
Automated backport with mergify
bug
Filebeat
Filebeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This modifies the gcp-pubsub input in Filebeat to include its own retry loop
rather than being entirely dependent upon the pub/sub client SDK to retry requests.
The input will only exit when the shutdown is triggered by Filebeat. Any errors
generated by the pub/sub client will be logged and then the input will restart the
pub/sub client. It will throttle restarts to once per 30s.
Fixes #32550
Why is it important?
This improves the reliability of the pub/sub input by handling errors that are not retried by the pub/sub SDK.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Logs