Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency elastic/go-structform from v0.0.9 to v0.0.10 #32536

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

florianl
Copy link
Member

Signed-off-by: Florian Lehner [email protected]

What does this PR do?

Update the dependency elastic/go-structform from v0.0.9 to v0.0.10.

Why is it important?

The dependency elastic/go-structform is used indirectly by the beats via elastic/beats/libbeat. v0.0.10 of elastic/go-structform includes changes to reduce the memory footprint and so does have an positive effect also on all beats.

Checklist

  • My code follows the style guidelines of this project
    PR does not introduce code changes.
  • I have commented my code, particularly in hard-to-understand areas
    PR does not introduce code changes.
  • I have made corresponding changes to the documentation
    PR does not introduce code changes.
  • I have made corresponding change to the default configuration files
    No configuration changes with this PR.
  • I have added tests that prove my fix is effective or that my feature works
    PR does not introduce code changes.
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@florianl florianl requested a review from a team as a code owner July 28, 2022 09:49
@florianl florianl requested review from rdner and cmacknz and removed request for a team July 28, 2022 09:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2022
@florianl florianl force-pushed the flo-update-structform branch from 58cf753 to fd5b670 Compare July 28, 2022 09:49
@florianl florianl added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 28, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 28, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 28, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-28T12:30:47.305+0000

  • Duration: 104 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 22536
Skipped 1937
Total 24473

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@florianl florianl force-pushed the flo-update-structform branch from fd5b670 to 92f6932 Compare July 28, 2022 10:11
@florianl
Copy link
Member Author

/test

@florianl florianl force-pushed the flo-update-structform branch from 92f6932 to 30f0359 Compare July 28, 2022 10:48
@florianl
Copy link
Member Author

/test

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
Copy link
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be released in 8.5.0 in October. We could backport to 8.4.0 to release it in August if there is a reason it is needed sooner.

Co-authored-by: Craig MacKenzie <[email protected]>
@florianl
Copy link
Member Author

We could backport [..] if there is a reason it is needed sooner

no requirement from my side. Thanks for offering.

@florianl
Copy link
Member Author

E2E Tests are failing because of these errors:


[2022-07-29T09:35:05.986Z] --- Failed steps:

[2022-07-29T09:35:05.987Z] 

[2022-07-29T09:35:05.987Z]   Scenario: Logs collection from running pod # features/filebeat.feature:6

[2022-07-29T09:35:05.987Z]     Given "filebeat" is running with "hints enabled" # features/filebeat.feature:7

[2022-07-29T09:35:05.987Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

[2022-07-29T09:35:05.987Z] 

[2022-07-29T09:35:05.987Z]   Scenario: Logs collection from failing pod # features/filebeat.feature:11

[2022-07-29T09:35:05.987Z]     Given "filebeat" is running with "hints enabled" # features/filebeat.feature:12

[2022-07-29T09:35:05.987Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

[2022-07-29T09:35:05.987Z] 

[2022-07-29T09:35:05.987Z]   Scenario: Logs collection from short-living cronjobs # features/filebeat.feature:18

[2022-07-29T09:35:05.987Z]     Given "filebeat" is running with "hints enabled" # features/filebeat.feature:19

[2022-07-29T09:35:05.987Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

[2022-07-29T09:35:05.987Z] 

[2022-07-29T09:35:05.987Z]   Scenario: Logs collection from a pod with an init container # features/filebeat.feature:24

[2022-07-29T09:35:05.987Z]     Given "filebeat" is running with "hints enabled" # features/filebeat.feature:25

[2022-07-29T09:35:05.987Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

[2022-07-29T09:35:05.987Z] 

[2022-07-29T09:35:05.987Z]   Scenario: Logs collection from a pod with an ephemeral container # features/filebeat.feature:32

[2022-07-29T09:35:05.987Z]     Given "filebeat" is running with "hints enabled" # features/filebeat.feature:33

[2022-07-29T09:35:05.987Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

[2022-07-29T09:35:05.987Z] 

[2022-07-29T09:35:05.987Z]   Scenario: Logs collection from running pod and metadata enrichment using add_kubernetes_metadata # features/filebeat.feature:41

[2022-07-29T09:35:05.988Z]     Given "filebeat" is running with "hints enabled" and "add_kubernetes_metadata" # features/filebeat.feature:42

[2022-07-29T09:35:05.988Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

[2022-07-29T09:35:05.988Z] 

[2022-07-29T09:35:05.988Z]   Scenario: Enrichment of normal input using add_kubernetes_metadata # features/filebeat.feature:48

[2022-07-29T09:35:05.988Z]     Given "filebeat" is running with "input with add_kubernetes_metadata" # features/filebeat.feature:49

[2022-07-29T09:35:05.988Z]       Error: Error response from daemon: No such image: docker.elastic.co/beats/filebeat:8.4.0-SNAPSHOT

Is this ok? @cmacknz
And if so, continue and merge the PR?

@florianl
Copy link
Member Author

florianl commented Aug 2, 2022

/package

@rdner rdner removed their request for review August 2, 2022 09:00
@florianl
Copy link
Member Author

florianl commented Aug 2, 2022

/package

1 similar comment
@florianl
Copy link
Member Author

florianl commented Aug 2, 2022

/package

@cmacknz
Copy link
Member

cmacknz commented Aug 2, 2022

The E2E test failures are unrelated, I can see almost the exact same set of failures happening on recent tests against main:

@cmacknz cmacknz merged commit 4f8694a into main Aug 2, 2022
@cmacknz cmacknz deleted the flo-update-structform branch August 2, 2022 19:40
andrewvc pushed a commit to andrewvc/beats that referenced this pull request Aug 3, 2022
…ic#32536)

* update dependency elastic/go-structform from v0.0.9 to v0.0.10

Signed-off-by: Florian Lehner <[email protected]>

Co-authored-by: Craig MacKenzie <[email protected]>

Co-authored-by: Craig MacKenzie <[email protected]>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* update dependency elastic/go-structform from v0.0.9 to v0.0.10

Signed-off-by: Florian Lehner <[email protected]>

Co-authored-by: Craig MacKenzie <[email protected]>

Co-authored-by: Craig MacKenzie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants