Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/module/checkpoint: add authentication operation outcome mapping #32431

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 21, 2022

What does this PR do?

This improves handling of authentication events with the Checkpoint module, syncing changes already made in the integration in elastic/integrations#3750.

Why is it important?

Information useful in SEIM was not being added to documents.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify 8.4-candidate labels Jul 21, 2022
@efd6 efd6 self-assigned this Jul 21, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2022
@efd6 efd6 force-pushed the 32230-checkpoint branch from e3dda32 to 1a0fb55 Compare July 21, 2022 06:00
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2022
@efd6 efd6 marked this pull request as ready for review July 21, 2022 06:00
@efd6 efd6 requested a review from a team as a code owner July 21, 2022 06:00
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Comment on lines +516 to +523
- gsub:
field: observer.mac
ignore_missing: true
pattern: '[:]'
replacement: '-'
- uppercase:
field: observer.mac
ignore_missing: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed after #32265 is merged, though maybe keeping it for parity with the integration is worthwhile.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-21T21:43:16.241+0000

  • Duration: 79 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 6317
Skipped 737
Total 7054

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 force-pushed the 32230-checkpoint branch from 1a0fb55 to 69c9373 Compare July 21, 2022 07:25
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4-candidate backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filebeat module Checkpoint - add ECS authentication fields for SIEM
3 participants