Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.3](backport #32281) [metricbeat] gcp: check for nil metadata #32400

Merged
merged 4 commits into from
Aug 25, 2022
Merged

[8.3](backport #32281) [metricbeat] gcp: check for nil metadata #32400

merged 4 commits into from
Aug 25, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #32281 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@gpop63 @mergify
[metricbeat] gcp: check for nil metadata (#32281)
0a87277 
* add check for nil metadata

* add changelog entry

(cherry picked from commit fa8d17f)
@mergify mergify bot requested a review from a team as a code owner July 19, 2022 10:38
@mergify mergify bot added the backport label Jul 19, 2022
@mergify mergify bot assigned gpop63 Jul 19, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 19, 2022
@botelastic
Copy link

botelastic bot commented Jul 19, 2022

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 19, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-24T15:46:59.970+0000

  • Duration: 55 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 1103
Skipped 87
Total 1190

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

sayden
sayden reviewed Jul 22, 2022
View reviewed changes
CHANGELOG.next.asciidoc
@@ -55,6 +55,9 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff]

*Metricbeat*

- update kubernetes apiserver metricset to not collect deprecated metrics and fix dashboard {pull}31973[31973]
- Check for nil metadata in GCP. {pull}32281[32281]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to fix this before merging :)

@mergify
Copy link
Contributor Author

mergify bot commented Jul 25, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Jul 26, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.3/pr-32281 upstream/mergify/bp/8.3/pr-32281
git merge upstream/8.3
git push upstream mergify/bp/8.3/pr-32281

@mergify
Copy link
Contributor Author

mergify bot commented Aug 1, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

3 similar comments
@mergify
Copy link
Contributor Author

mergify bot commented Aug 8, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Aug 15, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Aug 22, 2022

This pull request has not been merged yet. Could you please review and merge it @gpop63? 🙏

@gpop63 gpop63 requested a review from sayden August 24, 2022 10:22
sayden
sayden approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpop63 gpop63 merged commit 4678fc6 into 8.3 Aug 25, 2022
@mergify mergify bot deleted the mergify/bp/8.3/pr-32281 branch August 25, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@gpop63 gpop63

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @sayden @gpop63