-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new parser
called include_message
to filter messages
#32094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
requested review from
belimawr and
fearful-symmetry
and removed request for
a team
June 24, 2022 15:55
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 24, 2022
Collaborator
kvch
changed the title
Add new
Add new Jun 27, 2022
parser
called filter
to filter messagesparser
called include_message
to filter messages
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jun 27, 2022
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
rdner
reviewed
Jun 27, 2022
rdner
approved these changes
Jun 27, 2022
cmacknz
reviewed
Jun 27, 2022
cmacknz
reviewed
Jun 27, 2022
cmacknz
reviewed
Jun 27, 2022
cmacknz
approved these changes
Jun 27, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new parser to filter messages. If a message matches one of the patterns from the list, it is passed on to the next parser, otherwise it is dropped.
Why is it important?
The existing
include_lines
andexlcude_lines
filtering runs after theparsers
pipeline, so it is not possible to select messages before parsing them.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Closes #31794