Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][httpjson] Fix counter for number of published events #31993

Merged
merged 4 commits into from
Jul 19, 2022

Conversation

r00tu53r
Copy link
Contributor

@r00tu53r r00tu53r commented Jun 20, 2022

What does this PR do?

Fixes a counter that tracks the number of processed and published events when handling responses for httpjson input.

Why is it important?

The total number of events sent to ES would be logged incorrectly.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@r00tu53r r00tu53r added the bug label Jun 20, 2022
@r00tu53r r00tu53r requested a review from a team as a code owner June 20, 2022 06:15
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 20, 2022
@r00tu53r r00tu53r added the Draft label Jun 20, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-19T05:02:43.560+0000

  • Duration: 77 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 2170
Skipped 166
Total 2336

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test for this, but it's not critical.

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix/event-publish-counter upstream/fix/event-publish-counter
git merge upstream/main
git push upstream fix/event-publish-counter

@jsoriano
Copy link
Member

jsoriano commented Jul 4, 2022

I guess this could be merged? Could you please fix the conflicts in the changelog?

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 4, 2022
@r00tu53r r00tu53r removed the Draft label Jul 19, 2022
@r00tu53r r00tu53r merged commit fd0ae19 into elastic:main Jul 19, 2022
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Fix counter used for logging number of published events
* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants