Update kubernetes apiserver metrics and dashboard #31973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
MichaelKatsoulis
added
the
Team:Cloudnative-Monitoring
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
ChrsMark
reviewed
Jun 21, 2022
CHANGELOG.next.asciidoc
Outdated
| @@ -61,6 +61,7 @@ https://github.com/elastic/beats/compare/v8.2.0\...main[Check the HEAD diff] | |||
| - make `system/filesystem` code sensitive to `hostfs` and migrate libraries to `elastic-agent-opts` {pull}31001[31001] | |||
| - Fix kubernetes module's internal cache expiration issue. This avoid metrics like `kubernetes.container.cpu.usage.limit.pct` from not being populated. {pull}31785[31785] | |||
| - add missing HealthyHostCount and UnHealthyHostCount for application ELB. {pull}31853[31853] | |||
| - update kubernetes apiserver metricset to not collect deprecated metrics and fix dashboard | |||
| for _, event := range events { | ||
| if ok, _ := event.HasKey("request.count"); ok { |
There was a problem hiding this comment.
That's a really nice cleanup! 🍻
There was a problem hiding this comment.
That was ugly
| @@ -42645,16 +42645,6 @@ Kubernetes API server metrics | |||
|
|
|||
|
|
|||
|
|
|||
| *`kubernetes.apiserver.request.client`*:: | |||
There was a problem hiding this comment.
Add a note in the PR's description that it's not a breaking change but a bug fix instead to avoid future confusions.
ChrsMark
approved these changes
Jun 21, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Update kubernetes apiserver metrics and dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update kubernetes apiserver metrics and dashboard
Why is it important?
As described in #31834 apiserver metricset collects deprecated metrics from apiserver prometheus endpoint. These are:
http_request_duration_microsecondshttp_request_size_byteshttp_response_size_byteshttp_requests_totalapiserver_request_latenciesetcd_object_countsclientSome of those values can be taken instead from different prometheus fields:
http_request_duration_microseconds---> Nonehttp_response_size_bytes---> Nonehttp_requests_total---> Noneapiserver_request_latencies--->apiserver_request_duration_secondshttp_request_size_bytes---> Noneetcd_object_counts--->apiserver_storage_objectsAlso
apiserver_watch_events_sizesandapiserver_response_sizesare interesting metrics we where not collecting.As part of this PR the following elasticsearch fields have been dropped (they where null in the latest kubernetes versions (after 1.20))
kubernetes.apiserver.http.*kubernetes.apiserver.request.latency.*kubernetes.request.clientand new fields have been added:
kubernetes.apiserver.watch.events.kindkubernetes.apiserver.watch.events.size.bytes.*kubernetes.apiserver.response.size.bytes.*Also the OOTB dashboards where broken because they where using deprecated fields. They have been updated.
Checklist
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Closes Kubernetes Apiserver metricset collects deprecated metrics #31834
How to test this PR locally
Note
Bullet 3 of #31834 (comment). for storing prometheus histogram types as histograms in elasticsearch will be part of a follow up PR as the implementation needs further investigation. It requires a more generic solution and it is not only for apiserver.
Also removing the following elasticsearch fields as part of this PR should not be considered as a breaking changes, but as a bug fix as those fields where no longer populated to ES.
kubernetes.apiserver.http.*kubernetes.apiserver.request.latency.*kubernetes.request.client