Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winlogbeat: disentangle test data from x-pack/winlogbeat #31858

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 8, 2022

What does this PR do?

This makes the test data local to the testing code rather than reaching across the
filesystem. Also make some testing helpers more informative.

Why is it important?

The movement of test data in #31817 broke the tests here. This was not discovered until running tests in #31833 due to the non-locality of the data. The duplication of the data here fixes the tests and helps to prevent another case of this kind of breakage.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added bug Winlogbeat backport-skip Skip notification from the automated backport with mergify 8.4-candidate labels Jun 8, 2022
@efd6 efd6 requested a review from andrewkroh June 8, 2022 01:39
@efd6 efd6 requested a review from a team as a code owner June 8, 2022 01:39
@efd6 efd6 self-assigned this Jun 8, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2022
This makes the test data local to the testing code rather than reaching across the
filesystem. Also make some testing helpers more informative.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-08T02:18:34.602+0000

  • Duration: 80 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 22257
Skipped 1935
Total 24192

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 merged commit 090d8c1 into elastic:main Jun 9, 2022
@efd6 efd6 deleted the winlogbeattests branch June 9, 2022 06:10
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
This makes the test data local to the testing code rather than reaching across the
filesystem. Also make some testing helpers more informative.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.4-candidate backport-skip Skip notification from the automated backport with mergify bug Winlogbeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants