Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1.24 k8s version in testing list #31797

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Jun 1, 2022

What does this PR do?

Adds the new version of v1.24.0 in the list of the supported/tested versions.

Part of https://github.com/elastic/observability-dev/issues/2178.

@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Jun 1, 2022
@ChrsMark ChrsMark self-assigned this Jun 1, 2022
@ChrsMark ChrsMark requested review from a team as code owners June 1, 2022 14:15
@ChrsMark ChrsMark requested review from belimawr and kvch and removed request for a team June 1, 2022 14:15
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 1, 2022
Copy link
Contributor

@gizas gizas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will write this here as it happens that you already introduced me to this e2e tests,

It will be helpfull as a team to have WHAT, WHY and Test sections in our PRs
In this case in the Test section to have a link of successful Jenkins run or local commnd and screenshot for successful test run will give the info for the next one to repeat the test

@ChrsMark
Copy link
Member Author

ChrsMark commented Jun 1, 2022

I will write this here as it happens that you already introduced me to this e2e tests,

It will be helpfull as a team to have WHAT, WHY and Test sections in our PRs In this case in the Test section to have a link of successful Jenkins run or local commnd and screenshot for successful test run will give the info for the next one to repeat the test

Thank's for the review! Your suggestion totally makes sense! At the moment we already have a PR template that covers most of those, see for example #26056.
The template is part of the same repository at https://github.com/elastic/beats/blob/main/.github/PULL_REQUEST_TEMPLATE.md.

For simple PRs that do not involve significant amount of codebase changes I usually keep the description simple like in this one. Ofc it's up to the reviewer to ask for more information to be added in the description.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-01T14:15:49.544+0000

  • Duration: 107 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 22260
Skipped 1935
Total 24195

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ChrsMark ChrsMark merged commit d983d4a into elastic:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Automation Label for the Observability productivity team Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants