Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata for missing k8s resources/metricsets #31590

Merged
merged 8 commits into from
May 12, 2022
Merged

Add metadata for missing k8s resources/metricsets #31590

merged 8 commits into from
May 12, 2022

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented May 11, 2022 •
edited
Loading

What does this PR do?

Adds metadata for metricsets that were missing. For volume we can only add orchestrator related metadata since it's not an actual k8s object.

Why is it important?

To better filter objects in dashboards and visualisations.

Screenshots

Screenshot 2022-05-11 at 2 10 36 PM

Screenshot 2022-05-11 at 2 10 16 PM

Screenshot 2022-05-11 at 2 22 37 PM

Screenshot 2022-05-11 at 2 22 25 PM

@ChrsMark ChrsMark added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label May 11, 2022
@ChrsMark ChrsMark self-assigned this May 11, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 11, 2022
@ChrsMark
Fix roles
babf40b 
Signed-off-by: chrismark <[email protected]>
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 11, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T07:25:17.904+0000

  • Duration: 84 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 22013
Skipped 1800
Total 23813

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

ChrsMark added 4 commits May 11, 2022 12:15
@ChrsMark
fixup
627f2e5 
Signed-off-by: chrismark <[email protected]>
@ChrsMark
fix linter errors
d28a58c 
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Add changelog
02639e3 
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Add changelog
eb52dee 
Signed-off-by: chrismark <[email protected]>
@ChrsMark ChrsMark marked this pull request as ready for review May 11, 2022 11:29
@ChrsMark ChrsMark requested review from a team as code owners May 11, 2022 11:29
@ChrsMark ChrsMark requested review from cmacknz and leehinman and removed request for a team May 11, 2022 11:29
ChrsMark added 2 commits May 11, 2022 13:14
@ChrsMark
update playground files too
3dbd362 
Signed-off-by: chrismark <[email protected]>
@ChrsMark
Update tests
621dab9 
Signed-off-by: chrismark <[email protected]>
MichaelKatsoulis
MichaelKatsoulis approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@MichaelKatsoulis MichaelKatsoulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChrsMark ChrsMark merged commit e48882d into elastic:main May 12, 2022
This was referenced May 12, 2022
Merged
Merged
@tetianakravchenko tetianakravchenko mentioned this pull request Sep 8, 2022
Closed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@ChrsMark @chrisberkhout
Add metadata for missing k8s resources/metricsets (#31590)
3c4c1e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelKatsoulis MichaelKatsoulis MichaelKatsoulis approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@ChrsMark ChrsMark

Labels
8.3-candidate Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @elasticmachine @MichaelKatsoulis