List individual beat docs without a CODEOWNER. #31557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids having to maintain the correct codeowner for the entire docs tree, which is assignee that data plane team as reviewers for changes to code they do not own. The documentation for inputs and modules is frequently changed along with their code, so in practice a reasonable owner is assigned the majority of the time. When changes are made exclusively to these docs without any code change a reviewer will have to be manually assigned.
cmacknz
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jlind23
approved these changes
May 10, 2022
ruflin
approved these changes
May 10, 2022
kvch
approved these changes
May 10, 2022
cmacknz
added
backport-v8.2.0
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2022
This avoids having to maintain the correct codeowner for the entire docs tree, which is assignee that data plane team as reviewers for changes to code they do not own. The documentation for inputs and modules is frequently changed along with their code, so in practice a reasonable owner is assigned the majority of the time. When changes are made exclusively to these docs without any code change a reviewer will have to be manually assigned. (cherry picked from commit 5e93d5f)
mergify bot
pushed a commit
that referenced
this pull request
May 10, 2022
This avoids having to maintain the correct codeowner for the entire docs tree, which is assignee that data plane team as reviewers for changes to code they do not own. The documentation for inputs and modules is frequently changed along with their code, so in practice a reasonable owner is assigned the majority of the time. When changes are made exclusively to these docs without any code change a reviewer will have to be manually assigned. (cherry picked from commit 5e93d5f) # Conflicts: # .github/CODEOWNERS
cmacknz
added a commit
that referenced
this pull request
May 10, 2022
…#31570) * List individual beat docs without a CODEOWNER. (#31557) This avoids having to maintain the correct codeowner for the entire docs tree, which is assignee that data plane team as reviewers for changes to code they do not own. The documentation for inputs and modules is frequently changed along with their code, so in practice a reasonable owner is assigned the majority of the time. When changes are made exclusively to these docs without any code change a reviewer will have to be manually assigned. (cherry picked from commit 5e93d5f) # Conflicts: # .github/CODEOWNERS * Update CODEOWNERS to match main. Co-authored-by: Craig MacKenzie <[email protected]>
cmacknz
added a commit
that referenced
this pull request
May 10, 2022
This avoids having to maintain the correct codeowner for the entire docs tree, which is assignee that data plane team as reviewers for changes to code they do not own. The documentation for inputs and modules is frequently changed along with their code, so in practice a reasonable owner is assigned the majority of the time. When changes are made exclusively to these docs without any code change a reviewer will have to be manually assigned. (cherry picked from commit 5e93d5f) Co-authored-by: Craig MacKenzie <[email protected]>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
This avoids having to maintain the correct codeowner for the entire docs tree, which is assignee that data plane team as reviewers for changes to code they do not own. The documentation for inputs and modules is frequently changed along with their code, so in practice a reasonable owner is assigned the majority of the time. When changes are made exclusively to these docs without any code change a reviewer will have to be manually assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having to maintain the correct codeowner for the entire docs
tree, which is assignee that data plane team as reviewers for changes to
code they do not own.
The documentation for inputs and modules is frequently changed along with
their code, so in practice a reasonable owner is assigned the majority of the time.
When changes are made exclusively to these docs without any code change
a reviewer will have to be manually assigned.