-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orchestrator cluster ECS fields in k8s events #31341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <[email protected]>
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Apr 19, 2022
This pull request doesn't have a |
Signed-off-by: chrismark <[email protected]>
ChrsMark
requested review from
belimawr and
faec
and removed request for
a team
April 19, 2022 08:54
Collaborator
Signed-off-by: chrismark <[email protected]>
Signed-off-by: chrismark <[email protected]>
belimawr
approved these changes
Apr 19, 2022
tetianakravchenko
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MichaelKatsoulis
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kush-elastic
pushed a commit
to kush-elastic/beats
that referenced
this pull request
May 2, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.3.0
Automated backport with mergify
needs_team
Indicates that the issue/PR needs a Team:* label
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds ECS orchestrator fields for k8s events. This is not happening at the moment because events are being collected through "watchers" and the metadata generators are not applicable due to the nature of these objects. However we can directly add orchestrator metadata about the cluster.
Why is it important?
In order to be able to filter out events per cluster on Dashboards.
Closes elastic/integrations#3114
Sample ES event: