-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual backport][Heartbeat] Unpack beats in elastic-agent docker image #30873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilioalvap
added
bug
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
release-note:skip
The PR should be ignored when processing the changelog
Team:Elastic-Agent
Label for the Agent team
backport-7.17
Automated backport to the 7.17 branch with mergify
labels
Mar 16, 2022
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Mar 16, 2022
Pinging @elastic/uptime (Team:Uptime) |
Collaborator
/test |
@Mergifyio update |
✅ Branch has been successfully updated |
cmacknz
added
the
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
label
Mar 22, 2022
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
@Mergifyio update |
✅ Branch has been successfully updated |
michel-laterman
approved these changes
Mar 29, 2022
Hi @elastic/beats, could someone provide a review for this PR? Thanks! |
LGTM, you should be good with just the approval from the agent control plane team (which Michel has provided). |
mergify bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 37e2649)
emilioalvap
added a commit
that referenced
this pull request
Apr 19, 2022
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 37e2649) Co-authored-by: Emilio Alvarez Piñeiro <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7.17
Automated backport to the 7.17 branch with mergify
bug
release-note:skip
The PR should be ignored when processing the changelog
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of elastic/elastic-agent#202
What does this PR do?
This PR enables unpacking of beats inside the container at build time, so that required
cap_net_raw, cap_setuid
capabilities can be assigned to the binary.Why is it important?
Without the required capabilities, heartbeat cannot execute ICMP pings or setuid calls. As it is now, agent is unpacking beats at runtime, most likely with a user that doesn't have permission to assign capabilities.
Checklist
Author's Checklist
How to test this PR locally
DEV=true SNAPSHOT=true PLATFORMS=linux/amd64 TYPES=docker mage package
Related issues
Screenshots
Logs
15:38:37.323 elastic_agent.heartbeat [elastic_agent.heartbeat][info] heartbeat start running. 15:38:37.323 elastic_agent.heartbeat [elastic_agent.heartbeat][warn] BETA: Fleet management is enabled 15:38:37.323 elastic_agent.heartbeat [elastic_agent.heartbeat][info] Starting fleet management service 15:38:37.323 elastic_agent.heartbeat [elastic_agent.heartbeat][info] heartbeat is running! Hit CTRL-C to stop it. 15:38:37.323 elastic_agent.heartbeat [elastic_agent.heartbeat][info] Effective user/group ids: 1000/1000, with groups: [0]