-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release] Update test environments for 8.1.2 #30855
Conversation
This pull request doesn't have a |
testing/environments/prev-minor.yml
Outdated
@@ -3,7 +3,7 @@ | |||
version: '2.3' | |||
services: | |||
elasticsearch: | |||
image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-rc1 | |||
image: docker.elastic.co/elasticsearch/elasticsearch:8.1.0-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klacabane @matschaffer This looks off. Likely it should be 8.0.1 or similar? Same below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a little weird, yeah. Not sure what opens these PRs. Guessing something @elastic/observablt-robots manages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't manage this, the scripts are stored in ingest-dev
, the snippet for the specific makefile goal in charge of this, can be seen below:
PATCHNUM ?= $(shell echo $(CURRENT_RELEASE) | cut -f3 -d.)
LATEST_RELEASE ?= $(MAJOR).$(MINOR).$(shell expr $(PATCHNUM) - 1)
## @help:update-previous-minor-filebeat:Update the references on with the previous minor release for the filebeat previous minor testing stage
.PHONY: update-previous-minor-filebeat
update-previous-minor-filebeat:
ifeq ($(MAJOR),6)
echo '6.<minor> branch does not need to add any backport policy.'
else
cd beats; \
$(SED) -E -e "s#(image: docker\.elastic\.co/.*):[0-9]+\.[0-9]+\.[0-9]+#\1:$(LATEST_RELEASE)#g" testing/environments/prev-minor.yml
endif
and CURRENT_RELEASE=8.1.1
as stated in the branch automation
On the other hand, this particular automation was requested by @adriansr in #28274 in case it's required further details.
In a nutshell, I think rc1
was added back in the days in #30027, I don't know what's the version that should be added in this particular case :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the script is fine it is just not able to deal with -rc1 etc. As having rc1 etc. is kind of unique and an edge case, I suggest we clean it up manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matschaffer For the ping, I assumed this is because of stack monitoring that we test prev minor but it seems more generic, so we need to handle this from the Agent team.
This pull request is now in conflicts. Could you fix it? 🙏
|
I pushed a manual cleanup to the PR. |
@@ -3,7 +3,7 @@ | |||
version: '2.3' | |||
services: | |||
elasticsearch: | |||
image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-rc1 | |||
image: docker.elastic.co/elasticsearch/elasticsearch:8.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this should actually be 8.0.* I guess?
/test |
The build succeeded but the status still shows as pending in the PR, https://beats-ci.elastic.co/job/Beats/job/beats/job/PR-30855/4/ I'm going to merge this. |
Update test environment versions to the correct Elastic Stack version.
Merge only after the release of 8.1.1.