Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update test environments for 8.1.2 #30855

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Conversation

elasticmachine
Copy link
Collaborator

Update test environment versions to the correct Elastic Stack version.

Merge only after the release of 8.1.1.

@elasticmachine elasticmachine self-assigned this Mar 16, 2022
@elasticmachine elasticmachine added release Team:Automation Label for the Observability productivity team labels Mar 16, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 16, 2022
@elasticmachine elasticmachine requested a review from a team March 16, 2022 12:50
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 16, 2022
@botelastic
Copy link

botelastic bot commented Mar 16, 2022

This pull request doesn't have a Team:<team> label.

@@ -3,7 +3,7 @@
version: '2.3'
services:
elasticsearch:
image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-rc1
image: docker.elastic.co/elasticsearch/elasticsearch:8.1.0-rc1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klacabane @matschaffer This looks off. Likely it should be 8.0.1 or similar? Same below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a little weird, yeah. Not sure what opens these PRs. Guessing something @elastic/observablt-robots manages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't manage this, the scripts are stored in ingest-dev, the snippet for the specific makefile goal in charge of this, can be seen below:

PATCHNUM ?= $(shell echo $(CURRENT_RELEASE) | cut -f3 -d.)
LATEST_RELEASE ?= $(MAJOR).$(MINOR).$(shell expr $(PATCHNUM) - 1)

## @help:update-previous-minor-filebeat:Update the references on with the previous minor release for the filebeat previous minor testing stage
.PHONY: update-previous-minor-filebeat
update-previous-minor-filebeat:
ifeq ($(MAJOR),6)
	echo '6.<minor> branch does not need to add any backport policy.'
else
	cd beats; \
		$(SED) -E -e "s#(image: docker\.elastic\.co/.*):[0-9]+\.[0-9]+\.[0-9]+#\1:$(LATEST_RELEASE)#g" testing/environments/prev-minor.yml
endif

and CURRENT_RELEASE=8.1.1 as stated in the branch automation

On the other hand, this particular automation was requested by @adriansr in #28274 in case it's required further details.

In a nutshell, I think rc1 was added back in the days in #30027, I don't know what's the version that should be added in this particular case :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the script is fine it is just not able to deal with -rc1 etc. As having rc1 etc. is kind of unique and an edge case, I suggest we clean it up manually.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matschaffer For the ping, I assumed this is because of stack monitoring that we test prev minor but it seems more generic, so we need to handle this from the Agent team.

@elasticmachine
Copy link
Collaborator Author

elasticmachine commented Mar 16, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-22T14:57:55.790+0000

  • Duration: 132 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 25667
Skipped 2192
Total 27859

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_testing_env_next_8.1.2 upstream/update_testing_env_next_8.1.2
git merge upstream/8.1
git push upstream update_testing_env_next_8.1.2

@ruflin
Copy link
Contributor

ruflin commented Mar 18, 2022

I pushed a manual cleanup to the PR.

@@ -3,7 +3,7 @@
version: '2.3'
services:
elasticsearch:
image: docker.elastic.co/elasticsearch/elasticsearch:8.0.0-rc1
image: docker.elastic.co/elasticsearch/elasticsearch:8.1.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this should actually be 8.0.* I guess?

@cmacknz
Copy link
Member

cmacknz commented Mar 22, 2022

/test

@cmacknz
Copy link
Member

cmacknz commented Mar 23, 2022

The build succeeded but the status still shows as pending in the PR, https://beats-ci.elastic.co/job/Beats/job/beats/job/PR-30855/4/

I'm going to merge this.

@cmacknz cmacknz merged commit 0019da1 into 8.1 Mar 23, 2022
@cmacknz cmacknz deleted the update_testing_env_next_8.1.2 branch March 23, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants