Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor pushDockerImages main pipeline #30795

Merged
merged 3 commits into from
Mar 16, 2022
Merged

ci: refactor pushDockerImages main pipeline #30795

merged 3 commits into from
Mar 16, 2022

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 14, 2022 •
edited
Loading

What does this PR do?

Apply #30414 in the main pipeline.

Why is it important?

Packaging pipeline is aimed to run on merge commits, while main pipeline runs on a PR basis too. Let's align the implementation since the scripts are not anymore available in Beats but in the apm-pipeline-library (see elastic/apm-pipeline-library#1550)

Test

I committed 9aa8d30 to be able to trigger the package stage in the main pipeline:

image

and it worked:

image

image

https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-30795/4/pipeline/33261#step-34606-log-1

I'll revert those changes now

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 14, 2022
@v1v v1v self-assigned this Mar 14, 2022
@v1v v1v added backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Mar 14, 2022

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 14, 2022
@mergify mergify bot added backport-skip Skip notification from the automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Mar 14, 2022
@v1v v1v removed the backport-v8.0.0 Automated backport with mergify label Mar 14, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 14, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-15T16:19:40.933+0000

  • Duration: 86 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 25704
Skipped 2203
Total 27907

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v
Copy link
Member Author

v1v commented Mar 14, 2022

/test

@v1v
Copy link
Member Author

v1v commented Mar 14, 2022

Unfortunately, If I wanna test this out, I need to commit a change in any beats, since the pipeline changes won't run the packaging stage in the main pipeline.

@v1v v1v marked this pull request as ready for review March 15, 2022 16:19
@v1v v1v requested a review from a team as a code owner March 15, 2022 16:19
@v1v v1v added the Team:Automation Label for the Observability productivity team label Mar 15, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 15, 2022
@v1v v1v merged commit de3e4cc into elastic:main Mar 16, 2022
mergify bot pushed a commit that referenced this pull request Mar 16, 2022
@v1v
ci: refactor pushDockerImages main pipeline (#30795)
b289f58 
(cherry picked from commit de3e4cc)

# Conflicts:
#	Jenkinsfile
This was referenced Mar 16, 2022
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 16, 2022
@v1v
ci: refactor pushDockerImages main pipeline (#30795)
12eeb54 
(cherry picked from commit de3e4cc)
v1v added a commit that referenced this pull request Mar 16, 2022
@mergify @v1v
ci: refactor pushDockerImages main pipeline (#30795) (#30847)
cff6f35 
(cherry picked from commit de3e4cc)

Co-authored-by: Victor Martinez <[email protected]>
v1v pushed a commit that referenced this pull request Mar 17, 2022
@mergify
[7.17](backport #30795) ci: refactor pushDockerImages main pipeline (#…
6d9f9a5 
…30846)
kush-elastic pushed a commit to kush-elastic/beats that referenced this pull request May 2, 2022
@v1v @kush-elastic
ci: refactor pushDockerImages main pipeline (elastic#30795)
39dfd9e
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@v1v @chrisberkhout
ci: refactor pushDockerImages main pipeline (#30795)
f05db7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@v1v v1v

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v1v @elasticmachine @cachedout @kuisathaverat