Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MySQL Enterprise] Adding default paths values to manifest.yml #30598

Merged
merged 2 commits into from
Feb 28, 2022
Merged

[MySQL Enterprise] Adding default paths values to manifest.yml #30598

merged 2 commits into from
Feb 28, 2022

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Feb 28, 2022 •
edited
Loading

What does this PR do?

Adds a default value to the manifest.yml, this is needed to run pipeline setup commands, as it ignores user input.

Why is it important?

Fixes a bug when using filebeats setup command for this specific module

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@P1llus P1llus added Team:Security-External Integrations backport-v8.2.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Feb 28, 2022
@P1llus P1llus requested a review from a team February 28, 2022 12:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 28, 2022
@mergify mergify bot assigned P1llus Feb 28, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 28, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-28T12:35:22.306+0000

  • Duration: 109 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 2419
Skipped 159
Total 2578

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

taylor-swanson
taylor-swanson approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus P1llus merged commit 716a72c into elastic:main Feb 28, 2022
mergify bot pushed a commit that referenced this pull request Feb 28, 2022
@P1llus
[MySQL Enterprise] Adding default paths values to manifest.yml (#30598)
7916b77 
* adding default values to mysqlenterprise

* update changelog

(cherry picked from commit 716a72c)
@mergify mergify bot mentioned this pull request Feb 28, 2022
Merged
@P1llus P1llus added the backport-v8.1.0 Automated backport with mergify label Feb 28, 2022
@mergify mergify bot mentioned this pull request Feb 28, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 28, 2022
@P1llus
[MySQL Enterprise] Adding default paths values to manifest.yml (#30598)
f32a23a 
* adding default values to mysqlenterprise

* update changelog

(cherry picked from commit 716a72c)
P1llus added a commit that referenced this pull request Feb 28, 2022
@mergify @P1llus
[MySQL Enterprise] Adding default paths values to manifest.yml (#30598)…
7379c5f 
… (#30603)

* adding default values to mysqlenterprise

* update changelog

(cherry picked from commit 716a72c)

Co-authored-by: Marius Iversen <[email protected]>
P1llus added a commit that referenced this pull request Feb 28, 2022
@mergify @P1llus
[MySQL Enterprise] Adding default paths values to manifest.yml (#30598)…
23b8ae0 
… (#30604)

* adding default values to mysqlenterprise

* update changelog

(cherry picked from commit 716a72c)

Co-authored-by: Marius Iversen <[email protected]>
v1v added a commit that referenced this pull request Mar 2, 2022
@v1v
Merge branch '8.1' of github.com:elastic/beats into mergify/bp/8.1/pr…
0112148 
…-29710

* '8.1' of github.com:elastic/beats: (51 commits)
  refactor pushDockerImages (#30414) (#30624)
  ci: add windows-2022 in the extended meta-stage (#30528) (#30630)
  Curate k8s testing versions to only keep the actively maintained (#30619) (#30625)
  [8.1](backport #30355) Add Beats upgrade docs for 8.0 (#30612)
  Remove references to gcp from the Functionbeat docs (#30579) (#30609)
  x-pack/auditbeat/module/system/socket: defend against exec with zero arguments (#30586) (#30597)
  [MySQL Enterprise] Adding default paths values to manifest.yml (#30598) (#30604)
  metricbeat - fix elasticsearch and kibana integration tests failures in 8.0 (#30566) (#30594)
  Install gawk as a replacement for mawk in Docker containers. (#30452) (#30465)
  [Filebeat] Remove RecordedFuture dataset from Threat Intel module (#30564) (#30568)
  Adjust the documentation of `backoff` options in filestream input (#30552) (#30557)
  packetbeat/beater: help the GC clean up the Npcap installer if it's not used (#30513) (#30546)
  Osquerybeat: Add install verification for osquerybeat (#30388) (#30404)
  Update docker/distribution to 2.8.0 (#30462) (#30540)
  Add `parsers` examples to `filestream` reference configuration (#30529) (#30537)
  [8.1](backport #30068) ZooKeeper module: Adapt to ZooKeeper 3.6+ `mntr` response fields' changes. (#30360)
  [8.1](backport #30512) Switch skip to use `CI` (#30525)
  Forward-port 8.0.1 changelog to 8.1 (#30517)
  packetbeat/beater: don't attempt to install npcap when already installed (#30509) (#30511)
  Add drop and explicit tests to avoid duplicate ingest of elasticsearch logs (#30440) (#30488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@P1llus P1llus

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P1llus @elasticmachine @taylor-swanson