Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update breaking-8.0.asciidoc #30565

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Update breaking-8.0.asciidoc #30565

merged 2 commits into from
Feb 28, 2022

Conversation

nimarezainia
Copy link
Contributor

What does this PR do?

Why is it important?

Checklist

  • [ x] My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 23, 2022
@nimarezainia nimarezainia added the Team:Docs Label for the Observability docs team label Feb 23, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 23, 2022
dedemorton
dedemorton reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor editorial changes.

We need to get this into master, too, so I will forward port it after it's merged.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 23, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-24T22:35:07.575+0000

  • Duration: 25 min 49 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dedemorton
dedemorton approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this!

@dedemorton dedemorton added the backport-v8.1.0 Automated backport with mergify label Feb 28, 2022
@dedemorton dedemorton merged commit 767385e into 8.0 Feb 28, 2022
@dedemorton dedemorton deleted the nimarezainia-patch-1 branch February 28, 2022 23:29
mergify bot pushed a commit that referenced this pull request Feb 28, 2022
@nimarezainia
Update breaking-8.0.asciidoc (#30565)
f49086e 
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 767385e)
@mergify mergify bot mentioned this pull request Feb 28, 2022
Merged
dedemorton added a commit to dedemorton/beats that referenced this pull request Feb 28, 2022
@nimarezainia @dedemorton
Update breaking-8.0.asciidoc (elastic#30565)
4f09faa 
Co-authored-by: DeDe Morton <[email protected]>
@dedemorton dedemorton mentioned this pull request Feb 28, 2022
Merged
dedemorton added a commit that referenced this pull request Mar 1, 2022
@dedemorton @nimarezainia
Update breaking-8.0.asciidoc (#30565) (#30614)
ff8e234 
Co-authored-by: nima <[email protected]>
bmorelli25 pushed a commit that referenced this pull request Mar 21, 2022
@mergify @nimarezainia
Update breaking-8.0.asciidoc (#30565) (#30613)
ffe50c5 
Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 767385e)

Co-authored-by: nima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedemorton dedemorton dedemorton approved these changes

Assignees

@nimarezainia nimarezainia

Labels
backport-v8.1.0 Automated backport with mergify Team:Docs Label for the Observability docs team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nimarezainia @elasticmachine @dedemorton