-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch partition metricset from client to broker #3029
Changes from 1 commit
03cb921
9559407
2490e31
bd46985
cae454b
fb3ef8c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,14 +11,19 @@ | |
"id": 0 | ||
}, | ||
"offset": { | ||
"newest": 13, | ||
"newest": 11, | ||
"oldest": 0 | ||
}, | ||
"partition": 0, | ||
"replicas": [ | ||
0 | ||
], | ||
"topic": "testtopic" | ||
"partition": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This needs update. I will do a PR as soon as this is merged. |
||
"error": 0, | ||
"id": 0, | ||
"insync_replica": true, | ||
"leader": 0, | ||
"replica": 0 | ||
}, | ||
"topic": { | ||
"name": "test-metricbeat-8760238589576171408" | ||
} | ||
} | ||
}, | ||
"metricset": { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,14 +16,53 @@ | |
type: long | ||
description: > | ||
Oldest offset of the partition. | ||
- name: error | ||
type: long | ||
description: > | ||
Error code from fetching offset. | ||
|
||
- name: partition | ||
type: group | ||
description: > | ||
Partition data. | ||
fields: | ||
- name: id | ||
type: long | ||
description: > | ||
Partition id. | ||
|
||
- name: leader | ||
type: long | ||
description: > | ||
Leader id (broker). | ||
- name: isr | ||
type: list | ||
description: > | ||
List of isr ids. | ||
- name: replica | ||
type: long | ||
description: > | ||
Replica id (broker). | ||
|
||
- name: insync_replica | ||
type: boolean | ||
description: > | ||
Indicates if replica is included in the in-sync replicate set (ISR). | ||
|
||
- name: error | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm, if we switch this one to error_code, we would have to change the other 2 errors too. WDYT? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
type: long | ||
description: > | ||
Error code from fetching partition. | ||
|
||
- name: topic.error | ||
type: long | ||
description: > | ||
Partition id. | ||
- name: topic | ||
topic error. | ||
- name: topic.name | ||
type: keyword | ||
description: > | ||
Topic name | ||
|
||
- name: broker.id | ||
type: long | ||
description: > | ||
|
@@ -32,3 +71,5 @@ | |
type: keyword | ||
description: > | ||
Broker address | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, does this branch contain the sasl fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the branch is directly branched off from sasl-handshake.