Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heartbeat: add monitor.type to browser monitors #30187

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Heartbeat: add monitor.type to browser monitors #30187

merged 2 commits into from
Feb 3, 2022

Conversation

vigneshshanmugam
Copy link
Member

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 3, 2022
@vigneshshanmugam vigneshshanmugam added Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 3, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2022

This pull request does not have a backport label. Could you fix it @vigneshshanmugam? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 3, 2022
@vigneshshanmugam vigneshshanmugam added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify v8.1.0 and removed backport-skip Skip notification from the automated backport with mergify labels Feb 3, 2022
@vigneshshanmugam vigneshshanmugam requested review from andrewvc and a team February 3, 2022 16:09
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 3, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T16:27:06.152+0000

  • Duration: 52 min 36 sec

  • Commit: f038c42

Test stats 🧪

Test Results
Failed 0
Passed 120
Skipped 0
Total 120

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewvc
andrewvc approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc andrewvc merged commit 0c8b1b1 into elastic:main Feb 3, 2022
mergify bot pushed a commit that referenced this pull request Feb 3, 2022
@vigneshshanmugam
Heartbeat: add monitor.type to browser monitots (#30187)
1e385f7 
(cherry picked from commit 0c8b1b1)
andrewvc added a commit that referenced this pull request Feb 3, 2022
@andrewvc
Revert "Heartbeat: add monitor.type to browser monitots (#30187)"
2565365 
This reverts commit 0c8b1b1.
@mergify mergify bot mentioned this pull request Feb 3, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 3, 2022
@vigneshshanmugam
Heartbeat: add monitor.type to browser monitots (#30187)
da39b5f 
(cherry picked from commit 0c8b1b1)
@mergify mergify bot mentioned this pull request Feb 3, 2022
Merged
andrewvc pushed a commit that referenced this pull request Feb 3, 2022
@mergify @vigneshshanmugam
Heartbeat: add monitor.type to browser monitots (#30187) (#30194)
af18707 
(cherry picked from commit 0c8b1b1)

Co-authored-by: Vignesh Shanmugam <[email protected]>
andrewvc pushed a commit that referenced this pull request Feb 3, 2022
@mergify @vigneshshanmugam
Heartbeat: add monitor.type to browser monitots (#30187) (#30193)
29e1efd 
(cherry picked from commit 0c8b1b1)

Co-authored-by: Vignesh Shanmugam <[email protected]>
@vigneshshanmugam vigneshshanmugam added the backport-v8.1.0 Automated backport with mergify label Feb 3, 2022
@mergify mergify bot mentioned this pull request Feb 3, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 3, 2022
@vigneshshanmugam
Heartbeat: add monitor.type to browser monitots (#30187)
b0c6472 
(cherry picked from commit 0c8b1b1)
@vigneshshanmugam

This comment was marked as resolved.

Sign in to view
@mergify

This comment was marked as resolved.

Sign in to view
vigneshshanmugam added a commit that referenced this pull request Feb 3, 2022
@mergify @vigneshshanmugam
Heartbeat: add monitor.type to browser monitots (#30187) (#30196)
3cec185 
(cherry picked from commit 0c8b1b1)

Co-authored-by: Vignesh Shanmugam <[email protected]>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@andrewvc
Revert "Heartbeat: add monitor.type to browser monitots (elastic#30187)"
6e51fac 
This reverts commit 5186696.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vigneshshanmugam @elasticmachine @andrewvc