-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create elastic-agent-pull-requests.yml #30177
Conversation
This pull request does not have a backport label. Could you fix it @jlind23? 🙏
NOTE: |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not completely familiar with github action but the graphql looks good.
@v1v this beats-ci/pr-merge seems to fail because there is no changes made to the code base. Shouldn't we exclude some repositories from the check? |
@ph if you want give a try at a graphql request, github offers this: https://graphql.github.com/ |
@jlind23 I wonder why the action to add it to the Data plane board was skipped? |
@@ -0,0 +1,44 @@ | |||
name: Add to Elastic Agent Data Plane or Control Plane Board |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup it keeps only the last run in it.
@ruflin it was not. Each labelling generate an event on github side which then generate a github action run. |
/test |
Triggering the tests again as it seems it was aborted (manually?) |
@jlind23 , as far as I see there were two consecutive commits and the on-going builds were killed for the new one. That's the existing approach since the very beginning. If you click on #30177 (comment) you can see the previous build results. The comment contains as much details as possible regarding the build status. Let me know if that message is not clear and we can change it If no code changes, then only the linting is validated, we could exclude the .github folder, but for simplicity I'd rather prefer to run a basic linting than adding more complexity in the CI. What do you think? |
@v1v basic linting suits me well then. I am for reducing the complexity too. |
I think this is causing some CI failures because |
Automatically move PR to an Elastic Agent board as soon as they are labelled with either "team:elastic-agent-control-plane" or "team:elastic-agent-data-plane".