Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create elastic-agent-pull-requests.yml #30177

Merged
merged 3 commits into from
Feb 4, 2022
Merged

Conversation

jlind23
Copy link
Collaborator

@jlind23 jlind23 commented Feb 3, 2022

Automatically move PR to an Elastic Agent board as soon as they are labelled with either "team:elastic-agent-control-plane" or "team:elastic-agent-data-plane".

@jlind23 jlind23 requested review from ph, ruflin and cmacknz February 3, 2022 08:26
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 3, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2022

This pull request does not have a backport label. Could you fix it @jlind23? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 3, 2022
@jlind23 jlind23 added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed backport-skip Skip notification from the automated backport with mergify labels Feb 3, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 3, 2022
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Feb 3, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 3, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-04T08:39:14.432+0000

  • Duration: 14 min 29 sec

  • Commit: c8ff94b

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23 jlind23 added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team and removed Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Feb 3, 2022
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not completely familiar with github action but the graphql looks good.

@jlind23
Copy link
Collaborator Author

jlind23 commented Feb 4, 2022

@v1v this beats-ci/pr-merge seems to fail because there is no changes made to the code base. Shouldn't we exclude some repositories from the check?

@jlind23
Copy link
Collaborator Author

jlind23 commented Feb 4, 2022

@ph if you want give a try at a graphql request, github offers this: https://graphql.github.com/

@ruflin
Copy link
Contributor

ruflin commented Feb 4, 2022

@jlind23 I wonder why the action to add it to the Data plane board was skipped?

@@ -0,0 +1,44 @@
name: Add to Elastic Agent Data Plane or Control Plane Board
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If you shorten the title, this looks more descriptive.

Screenshot 2022-02-04 at 09 35 40

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup it keeps only the last run in it.

@jlind23
Copy link
Collaborator Author

jlind23 commented Feb 4, 2022

@ruflin it was not. Each labelling generate an event on github side which then generate a github action run.
2 labels means two runs. If you check each one of those you will find both condition being succesful.

@ruflin
Copy link
Contributor

ruflin commented Feb 4, 2022

/test

@ruflin
Copy link
Contributor

ruflin commented Feb 4, 2022

Triggering the tests again as it seems it was aborted (manually?)

@v1v
Copy link
Member

v1v commented Feb 4, 2022

@v1v this beats-ci/pr-merge seems to fail because there is no changes made to the code base. Shouldn't we exclude some repositories from the check?

@jlind23 , as far as I see there were two consecutive commits and the on-going builds were killed for the new one. That's the existing approach since the very beginning.

image

If you click on #30177 (comment) you can see the previous build results. The comment contains as much details as possible regarding the build status. Let me know if that message is not clear and we can change it

If no code changes, then only the linting is validated, we could exclude the .github folder, but for simplicity I'd rather prefer to run a basic linting than adding more complexity in the CI.

What do you think?

@jlind23
Copy link
Collaborator Author

jlind23 commented Feb 4, 2022

@v1v basic linting suits me well then. I am for reducing the complexity too.

@jlind23 jlind23 merged commit 2aee884 into main Feb 4, 2022
@cmacknz
Copy link
Member

cmacknz commented Feb 7, 2022

I think this is causing some CI failures because GITHUB_TOKEN is missing, example: https://github.com/elastic/beats/runs/5098115833?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants