Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Move changelog entries from breaking to bug #30113

Closed
wants to merge 2 commits into from

Conversation

andrewvc
Copy link
Contributor

These were in the wrong place by mistake

These were in the wrong place by mistake
@andrewvc andrewvc added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jan 31, 2022
@andrewvc andrewvc requested a review from justinkambic January 31, 2022 15:48
@andrewvc andrewvc self-assigned this Jan 31, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 31, 2022
@botelastic
Copy link

botelastic bot commented Jan 31, 2022

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2022

This pull request does not have a backport label. Could you fix it @andrewvc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 31, 2022
Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I did catch one misreference I should've seen before.

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-31T20:38:01.675+0000

  • Duration: 25 min 20 sec

  • Commit: 5ed8993

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andresrc
Copy link
Contributor

I fixed it directly in #30111, I think we can close this

Co-authored-by: Lucas F. da Costa <[email protected]>
@andrewvc andrewvc closed this Jan 31, 2022
@andrewvc andrewvc reopened this Jan 31, 2022
@andrewvc
Copy link
Contributor Author

@andresrc shouldn't we still correct the issue in master, or do you delete these entries once 7.17.0 is released

@andrewvc andrewvc closed this Jan 31, 2022
@andrewvc andrewvc reopened this Jan 31, 2022
@andresrc
Copy link
Contributor

andresrc commented Feb 1, 2022

@andrewvc I take care of moving things to master, we can close this one, thanks!

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b andrewvc-patch-2 upstream/andrewvc-patch-2
git merge upstream/master
git push upstream andrewvc-patch-2

@andresrc
Copy link
Contributor

andresrc commented Feb 4, 2022

Closing this as it has been fixed as part of the 7.17 (including forward ports) and 8.0 PRs

@andresrc andresrc closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants