Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/packetbeat: remove installation configurability #30048

Merged
merged 1 commit into from
Jan 31, 2022
Merged

x-pack/packetbeat: remove installation configurability #30048

merged 1 commit into from
Jan 31, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 27, 2022

What does this PR do?

This follows up #29112, removing the configurability that was included in that PR.

Why is it important?

It was decided that a simpler system would simplify support for the feature, reducing user configuration diversity. The configurablility was temporarily included to allow easier re-addition if there were to be strong community support for flexible configuration.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. Not a change in release.

Author's Checklist

N/A

How to test this PR locally

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A

@efd6 efd6 requested a review from andrewkroh January 27, 2022 05:25
@efd6 efd6 requested a review from a team as a code owner January 27, 2022 05:25
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 27, 2022
@efd6 efd6 removed the backport-v8.0.0 Automated backport with mergify label Jan 27, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-27T05:25:54.401+0000

  • Duration: 232 min 29 sec

  • Commit: f46b4ad

Test stats 🧪

Test Results
Failed 0
Passed 47979
Skipped 4285
Total 52264

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2022

This pull request does not have a backport label. Could you fix it @efd6? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 27, 2022
@efd6 efd6 merged commit e9a86da into elastic:master Jan 31, 2022
@efd6 efd6 deleted the npcap/installer-noconfig branch January 31, 2022 21:46
efd6 added a commit to efd6/beats that referenced this pull request Feb 22, 2022
@efd6
packetbeat/beater: help the GC clean up the Npcap installer if it's n…
90dfa59 
…ot used

The installer bytes are released in the install case but this was accidentally
removed in elastic#30048. This frees ~1MB of runtime memory after start up has been
completed.
@efd6 efd6 mentioned this pull request Feb 22, 2022
Merged
3 tasks
efd6 added a commit that referenced this pull request Feb 22, 2022
@efd6
packetbeat/beater: help the GC clean up the Npcap installer if it's n…
d76e445 
…ot used (#30513)

The installer bytes are released in the install case but this was accidentally
removed in #30048. This frees ~1MB of runtime memory after start up has been
completed.
mergify bot pushed a commit that referenced this pull request Feb 22, 2022
@efd6
packetbeat/beater: help the GC clean up the Npcap installer if it's n…
f4d5b0b 
…ot used (#30513)

The installer bytes are released in the install case but this was accidentally
removed in #30048. This frees ~1MB of runtime memory after start up has been
completed.

(cherry picked from commit d76e445)
efd6 added a commit that referenced this pull request Feb 23, 2022
@mergify @efd6
packetbeat/beater: help the GC clean up the Npcap installer if it's n…
693c6f1 
…ot used (#30513) (#30546)

The installer bytes are released in the install case but this was accidentally
removed in #30048. This frees ~1MB of runtime memory after start up has been
completed.

(cherry picked from commit d76e445)

Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
8.1-candidate backport-skip Skip notification from the automated backport with mergify enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @andrewkroh