Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osquerybeat/ext: Make packages non-internal. #29993

Merged

Conversation

yashtewari
Copy link
Contributor

What does this PR do?

Changes the following packages to be non-internal

  • github.com/elastic/beats/v7/x-pack/osquerybeat/ext/osquery-extension/internal/hostfs
  • github.com/elastic/beats/v7/x-pack/osquerybeat/ext/osquery-extension/internal/proc
  • github.com/elastic/beats/v7/x-pack/osquerybeat/ext/osquery-extension/internal/tables

Why is it important?

These packages can now be used from outside osquerybeat

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@yashtewari yashtewari requested a review from aleksmaus January 25, 2022 14:40
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 25, 2022

This pull request does not have a backport label. Could you fix it @yashtewari? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 25, 2022
Copy link
Contributor

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-25T14:40:59.241+0000

  • Duration: 64 min 7 sec

  • Commit: 9d0dab2

Test stats 🧪

Test Results
Failed 0
Passed 4083
Skipped 0
Total 4083

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aleksmaus aleksmaus added backport-v8.0.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 25, 2022
@yashtewari yashtewari added Team:Cloud-Security-Posture The CSP team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 26, 2022
@yashtewari yashtewari merged commit 2718e9b into elastic:master Jan 26, 2022
@yashtewari yashtewari deleted the osquerybeat-non-internal-pkgs branch January 26, 2022 09:24
mergify bot pushed a commit that referenced this pull request Jan 26, 2022
mtojek pushed a commit that referenced this pull request Jan 28, 2022
(cherry picked from commit 2718e9b)

Co-authored-by: Yash Tewari <[email protected]>
yashtewari added a commit to build-security/beats that referenced this pull request Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.0.0 Automated backport with mergify enhancement Team:Cloud-Security-Posture The CSP team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants