Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Fix some typos #29890

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[Elastic Agent] Fix some typos #29890

merged 2 commits into from
Jan 25, 2022

Conversation

AndersonQ
Copy link
Member

What does this PR do?

It fixes some typos and Go conventions on the code's comments.

Why is it important?

To keep consistent with the standard English.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@AndersonQ AndersonQ requested a review from a team as a code owner January 18, 2022 13:53
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 18, 2022

This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 18, 2022
@AndersonQ AndersonQ added enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team and removed needs_team Indicates that the issue/PR needs a Team:* label backport-skip Skip notification from the automated backport with mergify labels Jan 18, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 18, 2022
@AndersonQ AndersonQ added cleanup and removed enhancement backport-skip Skip notification from the automated backport with mergify labels Jan 18, 2022
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 18, 2022
@michel-laterman
Copy link
Contributor

/test

michel-laterman
michel-laterman approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor fix

x-pack/elastic-agent/pkg/agent/application/gateway/fleet/fleet_gateway.go Outdated
@@ -127,7 +127,7 @@ func newFleetGatewayWithScheduler(
stateStore stateStore,
) (gateway.FleetGateway, error) {

// Backoff implementation doesn't support the using context as the shutdown mechanism.
// Backoff implementation doesn't support the using of a context as the shutdown mechanism.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Backoff implementation doesn't support the using of a context as the shutdown mechanism.
// Backoff implementation doesn't support the using cancellation of a context as the shutdown mechanism.

Is this what is meant?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest either "Backoff implementation doesn't support using a context [cancellation] as the shutdown mechanism." or "Backoff implementation doesn't support the use of a context [cancellation] as the shutdown mechanism." (insert "cancellation" according to taste).

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 19, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-20T08:56:09.456+0000

  • Duration: 140 min 49 sec

  • Commit: 4da374c

Test stats 🧪

Test Results
Failed 0
Passed 47953
Skipped 4284
Total 52237

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@AndersonQ AndersonQ merged commit 3202b40 into master Jan 25, 2022
@AndersonQ AndersonQ deleted the fix-typos branch January 25, 2022 10:06
ph added a commit to ph/beats that referenced this pull request Jan 25, 2022
@ph
Revert changes in the artifact build from elastic#29890
79b58d5 
Revert changes introduced in elastic#29890 that prevented all the artifacts to
be build.
@ph ph mentioned this pull request Jan 25, 2022
Merged
6 tasks
ph added a commit that referenced this pull request Jan 26, 2022
@ph
Revert changes in the artifact build from #29890 (#30007)
a563681
v1v
v1v reviewed Jan 26, 2022
View reviewed changes
dev-tools/mage/crossbuild.go
// Types is the list of package types
var SelectedPackageTypes []PackageType
// SelectedPackageTypes is the list of package types
var SelectedPackageTypes []PackageType = []PackageType{TarGz}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? The description mentioned comments only, but this is code?

I see failures in the packaging

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a mistake, but it's been fixed already by #30007.

yashtewari pushed a commit to build-security/beats that referenced this pull request Jan 30, 2022
@AndersonQ @yashtewari
[Elastic Agent] Fix some typos (elastic#29890)
6102474
yashtewari pushed a commit to build-security/beats that referenced this pull request Jan 30, 2022
@ph @yashtewari
Revert changes in the artifact build from elastic#29890 (elastic#30007)
da06966
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 left review comments

@v1v v1v v1v left review comments

@michel-laterman michel-laterman michel-laterman approved these changes

@ph ph ph approved these changes

Assignees
No one assigned
Labels
backport-skip Skip notification from the automated backport with mergify cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AndersonQ @elasticmachine @michel-laterman @ph @v1v @efd6