-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get each command stats from INFO all command on redis module #29662
Conversation
💚 CLA has been signed |
This pull request does not have a backport label. Could you fix it @zanyou? 🙏
NOTE: |
I have signed the Contributor Agreement. |
Pinging @elastic/integrations (Team:Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on my redis version (6.2.6) I have also rejected_calls
and failed_calls
in cmdstat
what do you think about adding them as well?
@zanyou thanks for the contribution! please, see my comments |
@aspacca
These fields were added in redis 6.2 rc2 redis/redis#8305. But I didn't add it because the current module only tested with versions up to 5.0-rc4. I think it's a useful field, so I'll add it along with testing with 6.2.6. |
/test |
hi @zanyou , sorry for taking so long in review the last commits. all good on my side: once the CI is green we can merge |
@zanyou could please fix the python integration test? |
and also add an entry in the changelog :) |
/test |
Hi @aspacca , sorry for taking so long time. |
/test |
/test |
all good @zanyou , thanks for the contribution! |
What does this PR do?
This PR makes to collect redis commandstats on redis module.
This PR overlaps in purpose with #28012, but that PR looked like it needed a lot of fixing and had stopped being updated, so I created a new one.
Why is it important?
The current redis module are collect only default metrics from INFO command.
commandstats provide stats of each commands. It includes the number of calls and The total CPU time consumed by these commands. The information is very important for monitoring of redis.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
I had run only below commands. If need another tests, Please let me know.
Related issues
Use cases
Screenshots
Logs