Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elasticsearch.cluster.id to logstash metricsets #29625

Merged
merged 2 commits into from
Dec 29, 2021
Merged

add elasticsearch.cluster.id to logstash metricsets #29625

merged 2 commits into from
Dec 29, 2021

Conversation

klacabane
Copy link
Contributor

Summary

This change adds the elasticsearch.cluster.id to logstash metricsets to be consistent across stack monitoring modules.

@klacabane klacabane added Team:Integrations Label for the Integrations team Feature:Stack Monitoring v8.0.0 backport-v8.0.0 Automated backport with mergify v8.1.0 labels Dec 28, 2021
@klacabane klacabane self-assigned this Dec 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 28, 2021
@klacabane klacabane mentioned this pull request Dec 28, 2021
Closed
3 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 28, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-28T17:01:46.022+0000

  • Duration: 89 min 1 sec

  • Commit: 32ab935

Test stats 🧪

Test Results
Failed 0
Passed 9371
Skipped 2425
Total 11796

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

sayden
sayden approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@klacabane klacabane merged commit 1386a04 into elastic:master Dec 29, 2021
mergify bot pushed a commit that referenced this pull request Dec 29, 2021
@klacabane
add elasticsearch.cluster.id to logstash metricsets (#29625)
fc595f1 
* add elasticsearch.cluster.id to logstash metricsets

* changelog entry

(cherry picked from commit 1386a04)
@mergify mergify bot mentioned this pull request Dec 29, 2021
Merged
klacabane added a commit that referenced this pull request Dec 29, 2021
@mergify @klacabane
add elasticsearch.cluster.id to logstash metricsets (#29625) (#29636)
440ecaa 
* add elasticsearch.cluster.id to logstash metricsets

* changelog entry

(cherry picked from commit 1386a04)

Co-authored-by: Kevin Lacabane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees

@klacabane klacabane

Labels
backport-v8.0.0 Automated backport with mergify Feature:Stack Monitoring Team:Integrations Label for the Integrations team v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klacabane @elasticmachine @sayden