-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beat/kibana module - add {module}.elasticsearch.cluster.id property #29577
beat/kibana module - add {module}.elasticsearch.cluster.id property #29577
Conversation
Pinging @elastic/stack-monitoring (Stack monitoring) |
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
"running": c.Int("running"), | ||
"starts": c.Int("starts"), | ||
"stops": c.Int("stops"), | ||
"config": c.Dict("config", s.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add those fields in _meta/fields.yml
@matschaffer did your ES build include these mappings change ? What type of beat did you monitor and did it output to ES ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please, add a Changelog entry. Thanks!
…29577) * add elasticsearch.cluster.id property to beats state * add elasticsearch.cluster.id property to beats stats * fix test * lint * add missing reloads property * dont break earlier assumptions * remove trailing comma * update beats.stats fields * add updated fields doc * beat: update cluster.id path * kibana: update cluster.id path * mage fmt update * fix fields path * add missing map initialization * add changelog entry * fix pr number (cherry picked from commit 90dd169)
…h.cluster.id property (#29608) * beat/kibana module - add {module}.elasticsearch.cluster.id property (#29577) * add elasticsearch.cluster.id property to beats state * add elasticsearch.cluster.id property to beats stats * fix test * lint * add missing reloads property * dont break earlier assumptions * remove trailing comma * update beats.stats fields * add updated fields doc * beat: update cluster.id path * kibana: update cluster.id path * mage fmt update * fix fields path * add missing map initialization * add changelog entry * fix pr number (cherry picked from commit 90dd169) * remove non-backported changeset entries Co-authored-by: Kevin Lacabane <[email protected]>
Summary
This change adds the
beat.elasticsearch.cluster.id
property to bothstate
andstats
beat's metricsets, which is required for the SM UI to retrieve beats that outputs their events to a selected cluster.It also reverts this change as we should not be writing to other root module properties from a given module. This requires alias changes in elasticsearch to be functional.
The cluster ID was already available in the
state
metricset so it was just a matter of adding that property to the right path. For thestats
metricset I reused the 7.16 xpack logic.Testing
elasticsearch-xpack
module enabled