-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] httpjson - Add function to return User-Agent #29453 #29528
Conversation
This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This pull request is now in conflicts. Could you fix it? 🙏
|
120a71a
to
877df6e
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
NOTE: |
877df6e
to
3f3295f
Compare
@andrewkroh can u run the tests and review? |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments. Thanks for adding this.
6e78fed
to
cf4bcc8
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
6b055de
to
55c9f17
Compare
/test |
What does this PR do?
Adds a new value template function for the httpjson input to generate/update the User Agent.
Why is it important?
Some integrations require/prefer certain info to be in the user agent
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs