Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] httpjson - Add function to return User-Agent #29453 #29528

Merged
merged 7 commits into from
Dec 26, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Dec 19, 2021

What does this PR do?

Adds a new value template function for the httpjson input to generate/update the User Agent.

Why is it important?

Some integrations require/prefer certain info to be in the user agent

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 19, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 19, 2021

This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 19, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-26T21:14:54.606+0000

  • Duration: 12 min 29 sec

  • Commit: 55130a4

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 29453-useragent upstream/29453-useragent
git merge upstream/master
git push upstream 29453-useragent

@mtojek mtojek requested a review from a team December 21, 2021 11:58
@mtojek mtojek added Team:Security-External Integrations and removed backport-skip Skip notification from the automated backport with mergify labels Dec 21, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 21, 2021

This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 21, 2021
@legoguy1000
Copy link
Contributor Author

@andrewkroh can u run the tests and review?

@andrewkroh
Copy link
Member

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments. Thanks for adding this.

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
libbeat/common/useragent/useragent.go Outdated Show resolved Hide resolved
libbeat/common/useragent/useragent.go Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-httpjson.asciidoc Outdated Show resolved Hide resolved
x-pack/filebeat/docs/inputs/input-httpjson.asciidoc Outdated Show resolved Hide resolved
@andrewkroh
Copy link
Member

/test

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh merged commit 77d5969 into elastic:master Dec 26, 2021
@legoguy1000 legoguy1000 deleted the 29453-useragent branch December 30, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] httpjson - Add function to return User-Agent
4 participants