[heartbeat] Only add monitor.status to browser summary events #29460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
bug
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (Team:Uptime) |
botelastic
bot
added
needs_team
andrewvc
changed the title
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
justinkambic
approved these changes
Dec 17, 2021
vigneshshanmugam
approved these changes
Dec 17, 2021
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
we now only add monitor status to summary events for browsers. Additionally, this renames the poorly renamed wrappers/monitor* to wrappers/wrappers* (cherry picked from commit e3b1183)
|
@Mergifyio backport 7.17 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2021
we now only add monitor status to summary events for browsers. Additionally, this renames the poorly renamed wrappers/monitor* to wrappers/wrappers* (cherry picked from commit e3b1183)
✅ Backports have been created
|
vigneshshanmugam
pushed a commit
that referenced
this pull request
Dec 18, 2021
#29510) we now only add monitor status to summary events for browsers. Additionally, this renames the poorly renamed wrappers/monitor* to wrappers/wrappers* (cherry picked from commit e3b1183) Co-authored-by: Andrew Cholakian <[email protected]>
vigneshshanmugam
pushed a commit
that referenced
this pull request
Dec 18, 2021
#29509) we now only add monitor status to summary events for browsers. Additionally, this renames the poorly renamed wrappers/monitor* to wrappers/wrappers* (cherry picked from commit e3b1183) Co-authored-by: Andrew Cholakian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26325
we now only add monitor status to summary events for browsers. Additionally, this renames the poorly renamed
wrappers/monitor*towrappers/wrappers*Why is it important?
monitor.statusshould really only be set on unique components of events that constitute a full check. For lightweight checks that means checking an individual IP etc. A step represents progress toward a check, not the check itself. Hence this change.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
We'll want to check that this doesn't break any features in the synthetics UI as well. I'd index to kibana and check that nothing breaks.