Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Fix Cloudtrail Config #29450

Merged
merged 1 commit into from
Dec 17, 2021
Merged

[Filebeat] Fix Cloudtrail Config #29450

merged 1 commit into from
Dec 17, 2021

Conversation

legoguy1000
Copy link
Contributor

@legoguy1000 legoguy1000 commented Dec 15, 2021 •
edited
Loading

What does this PR do?

Fixes typo from #29415, here #29415 (comment).

Why is it important?

Re-add the endpoint config

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2021

This pull request does not have a backport label. Could you fix it @legoguy1000? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 15, 2021
@legoguy1000 legoguy1000 mentioned this pull request Dec 15, 2021
Merged
6 tasks
@legoguy1000
Copy link
Contributor Author

@aspacca @kaiyan-sheng Can you review and merge to fix my typo?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 15, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-15T21:32:31.986+0000

  • Duration: 125 min 15 sec

  • Commit: 5e46af3

Test stats 🧪

Test Results
Failed 0
Passed 4436
Skipped 309
Total 4745

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

kaiyan-sheng
kaiyan-sheng approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good catch! Thanks for fixing them!

@kaiyan-sheng
Copy link
Contributor

/test

@kaiyan-sheng kaiyan-sheng added backport-v8.0.0 Automated backport with mergify Team:Integrations Label for the Integrations team labels Dec 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 15, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Dec 15, 2021
@kaiyan-sheng kaiyan-sheng self-assigned this Dec 15, 2021
@kaiyan-sheng kaiyan-sheng merged commit 1b7d6e0 into elastic:master Dec 17, 2021
mergify bot pushed a commit that referenced this pull request Dec 17, 2021
@legoguy1000
Fix cloudtrail config (#29450)
c7fec55 
(cherry picked from commit 1b7d6e0)
@mergify mergify bot mentioned this pull request Dec 17, 2021
Merged
kaiyan-sheng added a commit that referenced this pull request Dec 17, 2021
@mergify @legoguy1000 @kaiyan-sheng
[8.0](backport #29450) [Filebeat] Fix Cloudtrail Config (#29507)
3268423 
* Fix cloudtrail config (#29450)

(cherry picked from commit 1b7d6e0)

* Update CHANGELOG.next.asciidoc

Co-authored-by: Alex Resnick <[email protected]>
Co-authored-by: kaiyan-sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport-v8.0.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legoguy1000 @elasticmachine @kaiyan-sheng