Add logs for ca_trusted_fingerprint workflow #29312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label. Could you fix it @belimawr? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
belimawr
changed the title
belimawr
added
backport-v8.0.0
botelastic
bot
removed
the
needs_team
mergify
bot
removed
the
backport-skip
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This commit adds logs to clearly show when Beats is trusting a self-signed certificate through a fingerprint provided by ssl.ca_trusted_fingerprint. It also cleans up some struct tags on tlscommon.TLSConfig.
belimawr
force-pushed
the
ca-trusted-fingerprint-logs
branch
from
b62cb5f to
fd29885
Compare
kvch
approved these changes
Dec 7, 2021
|
/test |
mergify bot
pushed a commit
that referenced
this pull request
Dec 7, 2021
This commit adds logs to clearly show when Beats is trusting a self-signed certificate through the fingerprint provided by `ssl.ca_trusted_fingerprint`. It also cleans up some struct tags on `tlscommon.TLSConfig`. (cherry picked from commit db9b410) # Conflicts: # libbeat/common/transport/tlscommon/tls_config.go
belimawr
added a commit
that referenced
this pull request
Dec 8, 2021
…29316) * Add logs for ca_trusted_fingerprint workflow (#29312) This commit adds logs to clearly show when Beats is trusting a self-signed certificate through the fingerprint provided by `ssl.ca_trusted_fingerprint`. It also cleans up some struct tags on `tlscommon.TLSConfig`. (cherry picked from commit db9b410) Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds logs to clearly show when Beats is trusting a self-signed certificate through a fingerprint provided by
ssl.ca_trusted_fingerprint.Why is it important?
If there is any issue connecting to an output (the main use case is ES >= 8.0) using a self-signed certificate it will be easier to debug/understand what is happening.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
tlslogger ("log.logger":"tls")Related issues
Use cases
Screenshots
Logs