fix: check the activation script exists on Python virtual environments #29265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
kuisathaverat
added
bug
ci
Team:Automation
botelastic
bot
removed
the
needs_team
kuisathaverat
changed the title
ruflin
approved these changes
Dec 6, 2021
|
I directly got this merged to update the related PR's. @kuisathaverat This should also be forwardported to master I assume? |
ruflin
pushed a commit
that referenced
this pull request
Dec 6, 2021
#29265) (#29279) (cherry picked from commit 52e87f0) Co-authored-by: Ivan Fernandez Calvo <[email protected]>
ruflin
pushed a commit
that referenced
this pull request
Dec 13, 2021
#29265) (#29288) (cherry picked from commit 52e87f0) Co-authored-by: Ivan Fernandez Calvo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes the way to check if the Python virtual environment is valid, not it check for the activation script instead of check only the existence of the folder.
Why is it important?
For some reason, the folder exists in the CI and it is empty, this forces to recreate it in case the activation script is not there.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.