Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null (\u0000) as a valid line terminator #28998

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Add null (\u0000) as a valid line terminator #28998

merged 1 commit into from
Nov 22, 2021

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Nov 16, 2021 •
edited
Loading

What does this PR do?

Add null (\u0000) as a valid line terminator called null_terminator.

Why is it important?

Closes: #27061

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

  1. Download null-terminated-log.txt.
  2. Configure filebeat to use filestream and read the file you downloaded.
  3. Start filebeat.
  4. Check that the log file as been correctly ingested.

Related issues

  • Closes 27061

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

This pull request does not have a backport label. Could you fix it @belimawr? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 16, 2021
@belimawr belimawr changed the title Add null \u0000 as a valid line terminator Add null (\u0000) as a valid line terminator Nov 16, 2021
@belimawr belimawr force-pushed the issue-27061-null-line-terminator branch from c55e6c4 to bb452e1 Compare November 16, 2021 15:43
@belimawr belimawr added review Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Nov 16, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@belimawr belimawr force-pushed the issue-27061-null-line-terminator branch from bb452e1 to 6726f70 Compare November 16, 2021 15:50
@belimawr belimawr requested a review from kvch November 16, 2021 15:51
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 16, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-18T14:39:00.858+0000

  • Duration: 124 min 33 sec

  • Commit: 046d765

Test stats 🧪

Test Results
Failed 0
Passed 54596
Skipped 5345
Total 59941

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@belimawr belimawr force-pushed the issue-27061-null-line-terminator branch 2 times, most recently from ade174f to 5eb5cb8 Compare November 18, 2021 09:33
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-27061-null-line-terminator upstream/issue-27061-null-line-terminator
git merge upstream/master
git push upstream issue-27061-null-line-terminator

@belimawr
Add null (\u0000) as a valid line terminator
046d765 
Add null (`\u0000`) as a valid line terminator called `null_terminator`.

Closes: elastic#27061
@belimawr belimawr force-pushed the issue-27061-null-line-terminator branch from 5eb5cb8 to 046d765 Compare November 18, 2021 14:38
@belimawr belimawr added backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 19, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 19, 2021
@belimawr belimawr merged commit 668da78 into elastic:master Nov 22, 2021
@belimawr belimawr deleted the issue-27061-null-line-terminator branch November 22, 2021 09:43
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
@belimawr
Add null (\u0000) as a valid line terminator (#28998)
26e3061 
Add null (`\u0000`) as a valid line terminator called `null_terminator`.

Closes: #27061
(cherry picked from commit 668da78)
@mergify mergify bot mentioned this pull request Nov 22, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 22, 2021
@belimawr
Add null (\u0000) as a valid line terminator (#28998)
cdd1fb3 
Add null (`\u0000`) as a valid line terminator called `null_terminator`.

Closes: #27061
(cherry picked from commit 668da78)
@mergify mergify bot mentioned this pull request Nov 22, 2021
Merged
v1v added a commit to v1v/beats that referenced this pull request Nov 22, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-a…
bb20e3d 
…ws-on-file-changes

* upstream/master:
  Fix discovery of Nomad allocations (elastic#28700)
  Add null (`\u0000`) as a valid line terminator (elastic#28998)
  Remove `logging.files.suffix` option and always use datetime suffixes (elastic#28927)
  x-pack/filebeat/module: add note for default var.input (elastic#28324)
  Fix AccessList & AccessMask processing in security data_stream (elastic#29016)
  [Metricbeat] Fix wrong mapping on "info" subkey (elastic#28782)
  ci: daily/weekly jobs (elastic#29050)
  [mergify] report open backported PRs once a week (elastic#28964)
belimawr added a commit that referenced this pull request Nov 24, 2021
@mergify @belimawr
Add null (\u0000) as a valid line terminator (#28998) (#29066)
414aee1 
Add null (`\u0000`) as a valid line terminator called `null_terminator`.

Closes: #27061
(cherry picked from commit 668da78)

Co-authored-by: Tiago Queiroz <[email protected]>
belimawr added a commit that referenced this pull request Nov 24, 2021
@mergify @belimawr
Add null (\u0000) as a valid line terminator (#28998) (#29067)
c2fb9a3 
Add null (`\u0000`) as a valid line terminator called `null_terminator`.

Closes: #27061
(cherry picked from commit 668da78)

Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees
No one assigned
Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify enhancement libbeat review Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add null (\u0000) as a valid line terminator.
3 participants
@belimawr @elasticmachine @kvch