-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SASL/SCRAM support to the Kafka test container #28971
Conversation
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label. Could you fix it @faec? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are a superhero! WFG.
(cherry picked from commit e69573a)
(cherry picked from commit e69573a)
(cherry picked from commit e69573a) Co-authored-by: Fae Charlton <[email protected]>
(cherry picked from commit e69573a) Co-authored-by: Fae Charlton <[email protected]>
What does this PR do?
Expands the configuration of the Kafka test container so that it adds a new external port 9093 that uses SASL/SCRAM authentication.
Why is it important?
As part of making SASL/SCRAM on Kafka GA, we want to include it in the automated tests, so our Kafka test container needs to support it (and include the certificates necessary for the client to connect).
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Create and start the container:
Point
kafka
at localhost (this is only needed to access the kafka broker from the host system, not another container, since on the Docker network the broker identifies itself by that name): edit/etc/hosts
to add the line127.0.0.1 kafka
.The server can now be accessed by beats on the host system, e.g. with this output configuration:
(the path in
certificate_authorities
should be modified if necessary to point atca-cert
in the test container directory).