-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kubernetes job name as the controller #28954
Add kubernetes job name as the controller #28954
Conversation
💚 CLA has been signed |
This pull request does not have a backport label. Could you fix it @wilsonge? 🙏
NOTE: |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
a1a075e
to
c3f898b
Compare
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/integrations (Team:Integrations) |
@wilsonge thank you for contributing this! The patch looks good to me already! Could you please rebase on top of latest master and also sign the CLA? |
c3f898b
to
c6d060c
Compare
Done |
/test |
07a2ef9
to
e443222
Compare
/test |
/package |
Thankyou @tetianakravchenko - it would be nice to have this backported into the 7.x series - but I guess you need to do the labels for that? |
here is a pr to backport it to 7.17 - #29679 |
Amazing thankyou! |
(cherry picked from commit eaa3b32)
…#29679) * Add kubernetes job name as the controller (#28954) (cherry picked from commit eaa3b32) * remove not relevand changelog records Signed-off-by: Tetiana Kravchenko <[email protected]> Co-authored-by: George Wilson <[email protected]>
What does this PR do?
This PR adds kubernetes.job.name in Pods' metadata.
Why is it important?
It enriches the documents of pods belonging to Jobs with the Job name.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Similar issue where metadata was added for daemonsets #26808