-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libbeat: add support for defining analyzers in-line in fields.yml files #28926
Conversation
2022b2b
to
2e12248
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
It's not obvious to me where documentation for this should go. So suggestions welcomed. |
Now I also see we have docs in https://www.elastic.co/guide/en/beats/devguide/current/event-fields-yml.html. That's probably what most contributors read rather than reading Go source. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That's perfect. Thanks.
:sadpanda: |
This pull request is now in conflicts. Could you fix it? 🙏
|
2e12248
to
69a09cb
Compare
@andrewkroh PTAL for docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…es (#28926) (#28981) (cherry picked from commit 62ec678) Co-authored-by: Dan Kortschak <[email protected]> Co-authored-by: Dan Kortschak <[email protected]>
What does this PR do?
This adds support for defining custom text analyzers in fields.yml files. For example:
Why is it important?
Not being able to define custom analyzers is a blocker for processing some documents containing syntactically meaningful non-standard token structures (for example captured script text as shown above).
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
No specific recommendations.
How to test this PR locally
Running
go test
in the relevant packages tests this change.Related issues
Use cases
Use case is shown above.
Screenshots
N/A
Logs
N/A