Add config option to attach pprof endpoints to http socket #28902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
enhancement
backport-v7.16.0
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
botelastic
bot
added
needs_team
|
I'm splitting apart and improving on some aspects of #28798 so its easier to review |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
efd6
reviewed
Nov 10, 2021
kvch
approved these changes
Nov 11, 2021
ruflin
approved these changes
Nov 11, 2021
| @@ -105,6 +105,7 @@ type beatConfig struct { | |||
|
|
|||
| // beat internal components configurations | |||
| HTTP *common.Config `config:"http"` | |||
| HTTPPprof *common.Config `config:"http.pprof"` | |||
There was a problem hiding this comment.
At first I was thinking this would conflict with the HTTP config one line before but it seems we have the same pattern on line 110/111?
There was a problem hiding this comment.
yeah, i followed the same pattern
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Add config option to attach pprof endpoints to http socket * Fix linting issues * add security note * Add pprof security docs (cherry picked from commit 3d54291)
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Add config option to attach pprof endpoints to http socket * Fix linting issues * add security note * Add pprof security docs (cherry picked from commit 3d54291)
michel-laterman
added a commit
that referenced
this pull request
Nov 16, 2021
…o http socket (#28978) * Add config option to attach pprof endpoints to http socket (#28902) * Add config option to attach pprof endpoints to http socket * Fix linting issues * add security note * Add pprof security docs (cherry picked from commit 3d54291) * Fix CHANGELOG Co-authored-by: Michel Laterman <[email protected]> Co-authored-by: michel-laterman <[email protected]>
michel-laterman
added a commit
that referenced
this pull request
Nov 16, 2021
…28979) * Add config option to attach pprof endpoints to http socket * Fix linting issues * add security note * Add pprof security docs (cherry picked from commit 3d54291) Co-authored-by: Michel Laterman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a config option to attach
/debug/pprof/endpoints to the stats handler enabled viahttp.enabled.Why is it important?
Currently pprof endpoints are only enabled when the
-httpprofflag is used; these endpoints are bound to a different socket then the stats endpoint. We would like to serve these endpoints on the same socket in order to unify calls from external processes.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Enable http and pprof when running a beat via
-E http.enabled=true -E http.pprof.enabled=true.Check the
/debug/pprof/endpoint via curlRelated issues