Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWS IAM permissions for VPC connected Lambda function #28789

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Update AWS IAM permissions for VPC connected Lambda function #28789

merged 1 commit into from
Feb 10, 2022

Conversation

avoidik
Copy link
Contributor

@avoidik avoidik commented Nov 3, 2021

What does this PR do?

This PR adds extra IAM permissions to be able to deploy VPC attached Lambda function in AWS.

Why is it important?

Without these three new permissions you won't be able to deploy VPC attached Lambda function in AWS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2021
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 3, 2021 •
edited
Loading

💚 CLA has been signed

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T10:17:52.403+0000

  • Duration: 20 min 11 sec

  • Commit: 1d34dc4

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mtojek
Copy link
Contributor

mtojek commented Nov 8, 2021

Hey @avoidik, could you please sign the CLA? Thanks!

@avoidik
Copy link
Contributor Author

avoidik commented Nov 21, 2021

@mtojek apologies for the delay, CLA is signed now

@ChrsMark ChrsMark added the Team:Integrations Label for the Integrations team label Dec 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2021
@ChrsMark
Copy link
Member

ChrsMark commented Dec 2, 2021

cc: @kaiyan-sheng @aspacca

@aspacca
Copy link

aspacca commented Dec 2, 2021

all good according to https://docs.aws.amazon.com/lambda/latest/dg/configuration-vpc.html

@kaiyan-sheng
Copy link
Contributor

/test

@kaiyan-sheng
Copy link
Contributor

@avoidik Can we actually make this change in the master branch and then we can backport it to 7.15? TIA!!

@avoidik avoidik changed the base branch from 7.15 to master December 6, 2021 09:40
@avoidik avoidik requested review from a team as code owners December 6, 2021 09:40
@avoidik avoidik changed the base branch from master to 7.15 December 6, 2021 09:40
@avoidik avoidik requested a review from a team as a code owner December 6, 2021 09:45
@avoidik avoidik changed the base branch from 7.15 to master December 6, 2021 09:46
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

This pull request does not have a backport label. Could you fix it @avoidik? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 6, 2021
@avoidik
Copy link
Contributor Author

avoidik commented Dec 6, 2021

here we go @kaiyan-sheng

@kaiyan-sheng kaiyan-sheng added backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Dec 6, 2021
@kaiyan-sheng kaiyan-sheng added backport-v7.15.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify labels Dec 6, 2021
@kaiyan-sheng
Copy link
Contributor

@avoidik Thank you!

@kaiyan-sheng
Copy link
Contributor

/test

@kaiyan-sheng
Copy link
Contributor

Seems like lint is not happy. Could you try to run mage update please? Thanks!

@kaiyan-sheng kaiyan-sheng removed backport-v8.1.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify labels Dec 7, 2021
@botelastic
Copy link

botelastic bot commented Jan 7, 2022

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jan 7, 2022
@aspacca
Copy link

aspacca commented Jan 10, 2022

@avoidik linting is failing, could you run mage update as suggested by @kaiyan-sheng ?
thanks!

@botelastic botelastic bot removed the Stalled label Jan 10, 2022
@avoidik
Copy link
Contributor Author

avoidik commented Jan 10, 2022

that's hard to imaging how PR to update 8 lines in documentation can be related to mage update, if I run mage update I get Unknown target specified: "update", hints?

@aspacca
Copy link

aspacca commented Jan 10, 2022

@avoidik , you have to run from x-pack/functionbeat
thanks

@mergify mergify bot assigned avoidik Feb 8, 2022
@aspacca aspacca added backport-v8.1.0 Automated backport with mergify and removed backport-v8.0.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Feb 10, 2022
@kaiyan-sheng kaiyan-sheng added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify labels Feb 10, 2022
@kaiyan-sheng kaiyan-sheng merged commit cfc69fd into elastic:main Feb 10, 2022
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@avoidik
Update AWS IAM permissions for VPC connected Lambda function (#28789)
43a3423 
(cherry picked from commit cfc69fd)
@mergify mergify bot mentioned this pull request Feb 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@avoidik
Update AWS IAM permissions for VPC connected Lambda function (#28789)
8aa27c0 
(cherry picked from commit cfc69fd)
@mergify mergify bot mentioned this pull request Feb 10, 2022
Merged
mergify bot pushed a commit that referenced this pull request Feb 10, 2022
@avoidik
Update AWS IAM permissions for VPC connected Lambda function (#28789)
f0b5069 
(cherry picked from commit cfc69fd)
@mergify mergify bot mentioned this pull request Feb 10, 2022
Merged
kaiyan-sheng pushed a commit that referenced this pull request Feb 11, 2022
@mergify @avoidik
Update AWS IAM permissions for VPC connected Lambda function (#28789) (…
ae58185 
…#30344)

(cherry picked from commit cfc69fd)

Co-authored-by: Viacheslav Vasilyev <[email protected]>
kaiyan-sheng pushed a commit that referenced this pull request Feb 11, 2022
@mergify @avoidik
Update AWS IAM permissions for VPC connected Lambda function (#28789) (…
50e13a2 
…#30347)

(cherry picked from commit cfc69fd)

Co-authored-by: Viacheslav Vasilyev <[email protected]>
kaiyan-sheng pushed a commit that referenced this pull request Feb 11, 2022
@mergify @avoidik
Update AWS IAM permissions for VPC connected Lambda function (#28789) (…
f6dcd5a 
…#30346)

(cherry picked from commit cfc69fd)

Co-authored-by: Viacheslav Vasilyev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspacca aspacca aspacca approved these changes

Assignees

@avoidik avoidik

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@avoidik @elasticmachine @mtojek @ChrsMark @aspacca @kaiyan-sheng