Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency issues with rpm package #28720

Closed
wants to merge 7 commits into from

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Oct 29, 2021

github.com/cavaliercoder/go-rpm has been renamed, and it seems to be causing some issues between the main go.mod and the go.mod of the custom beats generator.

Update dependencies to the new location.

Also, force the use of the current commit when testing the generator, to avoid using mixed versions (see comment).

Generator tests are failing in master with:

[2021-10-29T11:41:28.258Z] go: beatpath/testmetricbeat/tools imports
[2021-10-29T11:41:28.258Z] 	github.com/cavaliercoder/go-rpm: github.com/cavaliercoder/[email protected]: parsing go.mod:
[2021-10-29T11:41:28.258Z] 	module declares its path as: github.com/cavaliergopher/rpm
[2021-10-29T11:41:28.258Z] 	        but was required as: github.com/cavaliercoder/go-rpm
[2021-10-29T11:41:28.258Z] Error: running "go mod tidy" failed with exit code 1

@jsoriano jsoriano added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 29, 2021
@jsoriano jsoriano requested review from kvch and andrewkroh October 29, 2021 13:12
@jsoriano jsoriano self-assigned this Oct 29, 2021
@jsoriano jsoriano requested a review from a team as a code owner October 29, 2021 13:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 29, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

This pull request does not have a backport label. Could you fix it @jsoriano? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 29, 2021
@jsoriano jsoriano added the backport-v8.0.0 Automated backport with mergify label Oct 29, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 29, 2021
@jsoriano
Copy link
Member Author

/package

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 29, 2021

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-31T11:56:15.021+0000

  • Duration: 72 min 39 sec

  • Commit: 7956eda

Test stats 🧪

Test Results
Failed 0
Passed 20683
Skipped 1521
Total 22204

Steps errors 9

Expand to view the steps failures

generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 2 min 7 sec . View more details here
  • Description: make -C generator/_templates/metricbeat test test-package
generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 0 min 19 sec . View more details here
  • Description: make -C generator/_templates/metricbeat test test-package
generator-metricbeat-test - make -C generator/_templates/metricbeat test test-package
  • Took 0 min 18 sec . View more details here
  • Description: make -C generator/_templates/metricbeat test test-package
Archive system tests files
  • Took 0 min 0 sec . View more details here
  • Description: mage packageSystemTests
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 3 min 32 sec . View more details here
  • Description: make -C generator/_templates/beat test test-package
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 1 min 34 sec . View more details here
  • Description: make -C generator/_templates/beat test test-package
generator-beat-test - make -C generator/_templates/beat test test-package
  • Took 1 min 35 sec . View more details here
  • Description: make -C generator/_templates/beat test test-package
Archive system tests files
  • Took 0 min 0 sec . View more details here
  • Description: mage packageSystemTests
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 2'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@jsoriano jsoriano marked this pull request as draft October 29, 2021 17:47
@jsoriano
Copy link
Member Author

Marking as draft because these changes don't solve the issue.

@jsoriano jsoriano added the backport-v7.16.0 Automated backport with mergify label Oct 29, 2021
@jsoriano
Copy link
Member Author

jsoriano commented Nov 1, 2021

Closing this as this is not going to be done by now.

@jsoriano jsoriano closed this Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants