Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] Allow fingerprint processor to read @timestamp #28705

Merged
merged 1 commit into from
Nov 2, 2021
Merged

[libbeat] Allow fingerprint processor to read @timestamp #28705

merged 1 commit into from
Nov 2, 2021

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Use beat.Event.GetValue so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

Why is it important?

Allows for the @timestamp value to be incorporated into fingerprints.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewkroh
Allow fingerprint processor to read @timestamp
34f0922 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes elastic#28683
@andrewkroh andrewkroh requested a review from a team October 28, 2021 17:59
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 28, 2021
@andrewkroh andrewkroh added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Oct 28, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 28, 2021
@elastic elastic deleted a comment from mergify bot Oct 28, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-28T17:59:29.820+0000

  • Duration: 123 min 1 sec

  • Commit: 34f0922

Test stats 🧪

Test Results
Failed 0
Passed 54149
Skipped 5359
Total 59508

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@andrewkroh andrewkroh added the backport-v8.0.0 Automated backport with mergify label Nov 2, 2021
@andrewkroh andrewkroh merged commit 6390852 into elastic:master Nov 2, 2021
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
@andrewkroh
Allow fingerprint processor to read @timestamp (#28705)
0e38c73 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

(cherry picked from commit 6390852)
@mergify mergify bot mentioned this pull request Nov 2, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
@andrewkroh
Allow fingerprint processor to read @timestamp (#28705)
8368860 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

(cherry picked from commit 6390852)
@mergify mergify bot mentioned this pull request Nov 2, 2021
Merged
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
@andrewkroh
Allow fingerprint processor to read @timestamp (#28705)
ae734f5 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

(cherry picked from commit 6390852)
@mergify mergify bot mentioned this pull request Nov 2, 2021
Merged
andrewkroh added a commit that referenced this pull request Nov 2, 2021
@mergify @andrewkroh
Allow fingerprint processor to read @timestamp (#28705) (#28766)
4f8d721 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

(cherry picked from commit 6390852)

Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh added a commit that referenced this pull request Nov 2, 2021
@mergify @andrewkroh
Allow fingerprint processor to read @timestamp (#28705) (#28767)
835a241 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

(cherry picked from commit 6390852)

Co-authored-by: Andrew Kroh <[email protected]>
andrewkroh added a commit that referenced this pull request Nov 2, 2021
@mergify @andrewkroh
Allow fingerprint processor to read @timestamp (#28705) (#28768)
523cfb9 
Use `beat.Event.GetValue` so that @timestamp and @metadata are accessible to
be hashed.

Also clarify the documentation to explain how the value being hashed is constructed.

Fixes #28683

(cherry picked from commit 6390852)

Co-authored-by: Andrew Kroh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify bug libbeat :Processors review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libbeat] Fingerprint processor cannot access @timestamp
3 participants
@andrewkroh @elasticmachine @efd6