Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug][Elastic Agent] Fix endpoint constraint to enable arm64 #28677

Merged
merged 4 commits into from
Oct 28, 2021
Merged

[bug][Elastic Agent] Fix endpoint constraint to enable arm64 #28677

merged 4 commits into from
Oct 28, 2021

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

Constraint logic was a bit incorrect this PR makes it simpler to read and correct

Why is it important?

Fixes: #28442

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug backport-v7.16.0 Automated backport with mergify labels Oct 27, 2021
@michalpristas michalpristas self-assigned this Oct 27, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2021
@botelastic
Copy link

botelastic bot commented Oct 27, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 27, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-28T07:01:07.599+0000

  • Duration: 85 min 44 sec

  • Commit: 87dada6

Test stats 🧪

Test Results
Failed 0
Passed 7120
Skipped 16
Total 7136

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

michel-laterman
michel-laterman reviewed Oct 27, 2021
View reviewed changes
x-pack/elastic-agent/pkg/agent/program/testdata/endpoint_arm.yml
@@ -113,3 +113,5 @@ inputs:
network: true
runtime:
arch: arm64
family: redhat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this spec, what does this section do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a test file for testing endpoint will not be installed with certain runtime fields. this is used in TestConfiguration test in x-pack/elastic-agent/pkg/agent/program/program_test.go

see this change: https://github.com/elastic/beats/pull/27256/files#diff-baae09041516b8dab23e04ea74951edf4683919de0e2e35500158fe99fde088b

we populate these runtime fields based on env agent is running on so we can work with it within contraints or elsewhere in a program spec file

@michalpristas
Copy link
Contributor Author

test failures not related. i need to push this

@michalpristas michalpristas merged commit 8562134 into elastic:master Oct 28, 2021
@michalpristas michalpristas added the backport-v8.0.0 Automated backport with mergify label Oct 28, 2021
mergify bot pushed a commit that referenced this pull request Oct 28, 2021
@michalpristas
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677)
e83621e 
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677)

(cherry picked from commit 8562134)
@mergify mergify bot mentioned this pull request Oct 28, 2021
Merged
mergify bot pushed a commit that referenced this pull request Oct 28, 2021
@michalpristas
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677)
ba1978e 
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677)

(cherry picked from commit 8562134)
@mergify mergify bot mentioned this pull request Oct 28, 2021
Merged
michalpristas added a commit that referenced this pull request Oct 28, 2021
@mergify @michalpristas
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677) (…
d69e0a1 
…#28691)

[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677)

(cherry picked from commit 8562134)

Co-authored-by: Michal Pristas <[email protected]>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
@michalpristas
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (elastic…
50bd873 
…#28677)

[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (elastic#28677)
michalpristas added a commit that referenced this pull request Nov 2, 2021
@mergify @michalpristas
[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677) (…
7d50315 
…#28692)

[bug][Elastic Agent] Fix endpoint constraint to enable arm64 (#28677)

(cherry picked from commit 8562134)

Co-authored-by: Michal Pristas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman approved these changes

Assignees

@michalpristas michalpristas

Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify bug needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elastic Agent not bundling ARM/aarch64 Endpoint
3 participants
@michalpristas @elasticmachine @michel-laterman