Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standalone agent manifest conditions and scheduler and controllermanager default hosts #28675

Conversation

MichaelKatsoulis
Copy link
Contributor

What does this PR do?

After #27691 kubernetes.pod.labels are being populated under kubernetes.labels. The standalone agent manifest conditions have to be updated.
As part of this PR also the default hosts for controllermanager and scheduler are updated with the secure ports.

Why is it important?

Without this PR the conditions in the kubernetes autodiscover provider don't match any pod so the scheduler and controllermanager data streams do not work.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

This pull request does not have a backport label. Could you fix it @MichaelKatsoulis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 27, 2021
@MichaelKatsoulis MichaelKatsoulis added the Team:Integrations Label for the Integrations team label Oct 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2021
@MichaelKatsoulis MichaelKatsoulis added the backport-v7.16.0 Automated backport with mergify label Oct 27, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Oct 27, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-02T13:28:58.488+0000

  • Duration: 83 min 21 sec

  • Commit: f156186

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just add a changelog entry and should be ready to merge.

@mergify
Copy link
Contributor

mergify bot commented Nov 2, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-stadanalone-agent-manifest-conditions upstream/update-stadanalone-agent-manifest-conditions
git merge upstream/master
git push upstream update-stadanalone-agent-manifest-conditions

@MichaelKatsoulis MichaelKatsoulis added the backport-v8.0.0 Automated backport with mergify label Nov 2, 2021
@MichaelKatsoulis MichaelKatsoulis merged commit 223f070 into elastic:master Nov 2, 2021
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
…lermanager default hosts (#28675)

* Update standalone agent manifest conditions and scheduler and controllermanager default hosts

(cherry picked from commit 223f070)
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
…lermanager default hosts (#28675)

* Update standalone agent manifest conditions and scheduler and controllermanager default hosts

(cherry picked from commit 223f070)
MichaelKatsoulis pushed a commit that referenced this pull request Nov 3, 2021
…d scheduler and controllermanager default hosts (#28765)

* Update standalone agent manifest conditions and scheduler and controllermanager default hosts (#28675)
MichaelKatsoulis pushed a commit that referenced this pull request Nov 3, 2021
…nd scheduler and controllermanager default hosts (#28764)

* Update standalone agent manifest conditions and scheduler and controllermanager default hosts (#28675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify bug Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants