Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update test environments for 8.0.1 #28659

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

elasticmachine
Copy link
Collaborator

Update test environment versions to the correct Elastic Stack version.

Merge only after the release of 8.0.0.

@elasticmachine elasticmachine self-assigned this Oct 27, 2021
@elasticmachine elasticmachine added release Team:Automation Label for the Observability productivity team labels Oct 27, 2021
@elasticmachine elasticmachine requested a review from a team October 27, 2021 08:33
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 27, 2021
@elasticmachine
Copy link
Collaborator Author

elasticmachine commented Oct 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-28T12:45:14.257+0000

  • Duration: 130 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 37917
Skipped 3326
Total 41243

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_testing_env_next_8.0.1 upstream/update_testing_env_next_8.0.1
git merge upstream/8.0
git push upstream update_testing_env_next_8.0.1

@andresrc
Copy link
Contributor

/test

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update_testing_env_next_8.0.1 upstream/update_testing_env_next_8.0.1
git merge upstream/8.0
git push upstream update_testing_env_next_8.0.1

@ruflin
Copy link
Contributor

ruflin commented Feb 22, 2022

This one is failing with a zookeeper errror:

[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1704)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1705)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1706)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1707)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1708)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1709)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1710)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1711)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1712)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1713)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1714)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1715)[](https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats/detail/PR-28659/6/pipeline#step-19626-log-1716)[2022-02-21T16:57:43.811Z] Recreating metricbeat_8_0_1_dfc5ef59f8-snapshot_zookeeper_1 ... done

[2022-02-21T16:57:43.811Z]     zookeeper_integration_test.go:36: 

[2022-02-21T16:57:43.811Z]         	Error Trace:	zookeeper_integration_test.go:36

[2022-02-21T16:57:43.811Z]         	Error:      	Received unexpected error:

[2022-02-21T16:57:43.811Z]         	            	no 'serverId' found in 'conf' response

[2022-02-21T16:57:43.811Z]         	            	github.com/elastic/beats/v7/metricbeat/module/zookeeper.ServerID

[2022-02-21T16:57:43.811Z]         	            		/go/src/github.com/elastic/beats/metricbeat/module/zookeeper/zookeeper.go:82

[2022-02-21T16:57:43.811Z]         	            	github.com/elastic/beats/v7/metricbeat/module/zookeeper.TestServerID

[2022-02-21T16:57:43.811Z]         	            		/go/src/github.com/elastic/beats/metricbeat/module/zookeeper/zookeeper_integration_test.go:35

[2022-02-21T16:57:43.811Z]         	            	testing.tRunner

[2022-02-21T16:57:43.811Z]         	            		/usr/local/go/src/testing/testing.go:1259

[2022-02-21T16:57:43.811Z]         	            	runtime.goexit

[2022-02-21T16:57:43.811Z]         	            		/usr/local/go/src/runtime/asm_amd64.s:1581

[2022-02-21T16:57:43.811Z]         	Test:       	TestServerID

There have been recently some changes to zookeeper so I wonder if it is related? @jsoriano ?

BTW also zookeeper for the system tests: https://beats-ci.elastic.co/job/Beats/job/beats/job/PR-28659/6/consoleText

@jsoriano
Copy link
Member

jsoriano commented Feb 22, 2022

Discussed offline, this may be related to #30068. After these changes images are cached and they may be unexpectedly reused by other branches, same tag is used.

@jsoriano
Copy link
Member

I will backport the required changes 🤞

@ph
Copy link
Contributor

ph commented Feb 22, 2022

Thanks @jsoriano

@jsoriano
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 22, 2022

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@ruflin
Copy link
Contributor

ruflin commented Feb 23, 2022

There seems to be an error with the Elasticsearch and Kibana tests:

[2022-02-22T17:09:17.454Z] ok  	github.com/elastic/beats/v7/metricbeat/module/kibana	0.034s	coverage: 12.9% of statements
[2022-02-22T17:09:17.454Z] ?   	github.com/elastic/beats/v7/metricbeat/module/kibana/mtest	[no test files]
[2022-02-22T17:10:13.875Z] FAIL
[2022-02-22T17:10:13.875Z] FAIL	github.com/elastic/beats/v7/metricbeat/module/kibana/settings	53.147s
[2022-02-22T17:10:13.875Z] ok  	github.com/elastic/beats/v7/metricbeat/module/kibana/status	54.706s	coverage: 78.4% of statements
[2022-02-22T17:10:13.875Z] ok  	github.com/elastic/beats/v7/metricbeat/module/kibana/stats	56.394s	coverage: 70.0% of statements
[2022-02-22T17:10:13.875Z] 
[2022-02-22T17:10:13.875Z] === Skipped
[2022-02-22T17:10:13.875Z] === SKIP: metricbeat/module/kibana/settings TestData (1.92s)
[2022-02-22T17:10:13.875Z]     data_generator.go:72: skip data generation tests
[2022-02-22T17:10:13.875Z] 
[2022-02-22T17:10:13.875Z] === SKIP: metricbeat/module/kibana/stats TestData (2.16s)
[2022-02-22T17:10:13.875Z]     data_generator.go:72: skip data generation tests
[2022-02-22T17:10:13.875Z] 
[2022-02-22T17:10:13.875Z] === Failed
[2022-02-22T17:10:13.875Z] === FAIL: metricbeat/module/kibana/settings TestFetch (51.17s)
[2022-02-22T17:10:13.875Z]     settings_integration_test.go:57: 
[2022-02-22T17:10:13.875Z]         	Error Trace:	settings_integration_test.go:57
[2022-02-22T17:10:13.875Z]         	Error:      	Should be empty, but was [HTTP error 404 in : 404 Not Found]
[2022-02-22T17:10:13.875Z]         	Test:       	TestFetch
[2022-02-22T17:10:13.875Z] 
[2022-02-22T17:10:13.875Z] DONE 6 tests, 2 skipped, 1 failure in 61.433s
[2022-02-22T17:10:13.875Z] Error: failed modules: kibana

There might be some breaking change in 8.0 where the files are not adjusted yet? :-(

@jsoriano
Copy link
Member

These tests pass on my machine ™️ , maybe they are flaky? cc @klacabane @matschaffer

@jsoriano
Copy link
Member

/test

@jsoriano
Copy link
Member

These tests pass on my machine tm , maybe they are flaky? cc @klacabane @matschaffer

Sorry, I was trying with the wrong branch 🤦 These failures are reproducible locally, they may be actual issues with these modules.

@ph
Copy link
Contributor

ph commented Feb 23, 2022

Can we clarify who is looking into the failures?

@jsoriano
Copy link
Member

Can we clarify who is looking into the failures?

Sorry, I am not looking into them, I only checked in case they were flaky. I think we need someone with more context on these modules to decide what to do.

Failure in elasticsearch seems easy, it seems it is only about some new fields that are not properly documented, but no idea about the kibana one.

@matschaffer @klacabane could you please take a look?

@klacabane
Copy link
Contributor

klacabane commented Feb 23, 2022

I'll have a look


For the kibana failure it seems that the /settings api was removed in 8.0 as it now returns 404. This is a breaking change for customers that explicitly define the metricset in the module's configuration, but we don't collect the metricset by default whether xpack.enabled is true or false. I didn't find documentation on that API removal yet API removal ticket - the data returned by the settings api is included in the stats metricset, we should clean up the metricset with the tests that go along.

@klacabane
Copy link
Contributor

Fixes for both elasticsearch/kibana failures ready for review in #30566

@ruflin
Copy link
Contributor

ruflin commented Feb 28, 2022

@klacabane Thanks for the changes. Lets get it in and backported quickly to unblock this PR. Can you ping here when it is ready. I just approved #30566 .

@ruflin
Copy link
Contributor

ruflin commented Feb 28, 2022

Found the answer to my question, main still tests against 7.14 ... https://github.com/elastic/beats/blob/main/metricbeat/docker-compose.yml#L20 We need to fix this.

@ruflin
Copy link
Contributor

ruflin commented Feb 28, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

update

✅ Branch has been successfully updated

Hey, I reacted but my real name is @Mergifyio

@andresrc andresrc merged commit 38c9336 into 8.0 Mar 1, 2022
@andresrc andresrc deleted the update_testing_env_next_8.0.1 branch March 1, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants