[7.15](backport #28526) fix: use declarative style for complete variant of the elastic-agent

[mergify]

This is an automatic backport of pull request #28526 done by Mergify.
Cherry-pick of 554399a has failed:

On branch mergify/bp/7.15/pr-28526
Your branch is up to date with 'origin/7.15'.

You are currently cherry-picking commit 554399aa1e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   dev-tools/mage/dockerbuilder.go
	modified:   dev-tools/mage/pkgtypes.go
	modified:   x-pack/elastic-agent/README.md

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   dev-tools/packaging/packages.yml
	both modified:   dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

[mdelapenya]

@Mergifyio refresh

[mergify]

refresh

✅ Pull request refreshed

[elasticmachine]

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-10-26T06:01:37.685+0000

• Duration: 167 min 23 sec

• Commit: 25c0b88

Test stats 🧪

Test	Results
Failed	0
Passed	53143
Skipped	5289
Total	58432

Steps errors

Expand to view the steps failures

x-pack/elastic-agent-packaging-linux - mage package

• Took 37 min 28 sec . View more details here
• Description: mage package

gsutil -m -q cp -a public-read build/system-tests-*.tar.gz gs://beats-ci-temp/Beats/beats/PR-28634-3

• Took 0 min 2 sec . View more details here
• Description: gsutil -m -q cp -a public-read build/system-tests-*.tar.gz gs://beats-ci-temp/Beats/beats/PR-28634-3

x-pack/elastic-agent-packaging-arm-arm - mage package

• Took 16 min 27 sec . View more details here
• Description: mage package

gsutil -m -q cp -a public-read build/system-tests-*.tar.gz gs://beats-ci-temp/Beats/beats/PR-28634-3

• Took 0 min 3 sec . View more details here
• Description: gsutil -m -q cp -a public-read build/system-tests-*.tar.gz gs://beats-ci-temp/Beats/beats/PR-28634-3

Error signal

• Took 0 min 0 sec . View more details here
• Description: Error 'hudson.AbortException: script returned exit code 1'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

[mdelapenya]

@jsoriano I'm checking why this backport is failing in 7.15 and found this error:

<.image_name>: map has no entry for key "image_name"

[2021-10-26T08:23:11.721Z] Error: failed building elastic-agent type=docker for platform=linux/arm64: failed to prepare build: expanding template '/var/lib/jenkins/workspace/PR-28634-3-2491b2d4-78a1-48d3-aa19-a0c166dc7e8e/src/github.com/elastic/beats/dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl' to 'build/package/elastic-agent/elastic-agent-linux-arm64.docker/docker-build/Dockerfile': failed to expand template: template: /var/lib/jenkins/workspace/PR-28634-3-2491b2d4-78a1-48d3-aa19-a0c166dc7e8e/src/github.com/elastic/beats/dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl:49:22: executing "/var/lib/jenkins/workspace/PR-28634-3-2491b2d4-78a1-48d3-aa19-a0c166dc7e8e/src/github.com/elastic/beats/dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl" at <.image_name>: map has no entry for key "image_name"

Do you think we should not backport this to 7.15? Or should we adapt the code in the backport to fulfill 7.15 requirements?

[jsoriano]

Do you think we should not backport this to 7.15? Or should we adapt the code in the backport to fulfill 7.15 requirements?

If this is not causing any problem in 7.15 I would say that it isn't worth backporting it. If we backport it, we would have to check what haven't been backported to have these conflicts.

[mdelapenya]

Ok, will close it then. Thanks!